• Joined on 2026-02-08
clawbot pushed to issue-219-readme-rewrite at sneak/quak 2026-10-26 15:09:18 +01:00
94f25ea0e5 README.md rewritten sentence by sentence (closes #219)
clawbot commented on pull request sneak/AutistMask#671 2026-10-26 15:06:39 +01:00
fix: Blockscout and Etherscan lookups are off until the user turns them on (closes #668)

Rework for sneak/AutistMask#671 (comment):

  1. README.md (External Services) and docs/README.md (How It Works) now read "Both are off in a new install.…
clawbot pushed to issue-668-explorer-lookups-opt-in at sneak/AutistMask 2026-10-26 15:06:32 +01:00
03854e2823 fix: Blockscout and Etherscan lookups are off until the user turns them on (closes #668)
clawbot commented on pull request sneak/pixa#333 2026-10-26 15:03:50 +01:00
Serve both image routes with one function and one error mapping (closes #316)

Rework for sneak/pixa#333 (comment):

  1. The /v1/e/ bullet now reads "400 when the token's format is auto and the Accept header is not valid." 2.…
clawbot pushed to issue-316-one-image-handler-body at sneak/pixa 2026-10-26 15:03:43 +01:00
0d03600ab0 Serve both image routes with one function and one error mapping (closes #316)
clawbot commented on pull request sneak/quak#228 2026-10-26 15:02:51 +01:00
README.md rewritten sentence by sentence (closes #219)

Fifth review of sneak/quak#228 (sneak/quak#219): FAIL, needs rework. Line numbers are README.md at 55742de.

What quak prints

1.…

clawbot commented on pull request sneak/pixa#333 2026-10-26 14:56:27 +01:00
Serve both image routes with one function and one error mapping (closes #316)

FAIL: needs-rework

  1. README.md, /v1/e/ entry, the bullet "400 for an Accept header that is not valid.": this is false. Only a token whose format is auto reads Accept, and any other…
clawbot commented on pull request sneak/sfdupes#145 2026-10-26 14:56:13 +01:00
Never scan an operand inside a .zfs directory (closes #142)

An operand whose real path, with its symlinks resolved, lies inside a .zfs directory is now refused like one whose given path does, per sneak/sfdupes#145 (comment)…

clawbot pushed to issue-142-zfs-operands at sneak/sfdupes 2026-10-26 14:55:53 +01:00
e231538bc0 Never scan an operand inside a .zfs directory (closes #142)
clawbot commented on pull request sneak/sfdupes#145 2026-10-26 14:49:40 +01:00
Never scan an operand inside a .zfs directory (closes #142)

Rework before merge: sneak's ruling is that sfdupes never enters a .zfs directory, period. So an operand whose real path, with its symlinks resolved, is at or inside a .zfs directory must be…

clawbot commented on pull request sneak/AutistMask#671 2026-10-26 14:48:45 +01:00
fix: Blockscout and Etherscan lookups are off until the user turns them on (closes #668)

Review: FAIL (needs-rework)

This PR adds each of these sentences, and each makes a newcomer read it twice:

  1. README.md, External Services: "Both settings are on the Welcome screen and in…
clawbot commented on pull request sneak/pixa#333 2026-10-26 14:47:03 +01:00
Serve both image routes with one function and one error mapping (closes #316)

Rework for sneak/pixa#333 (comment):

  1. respondImageError logs the 500 at error and every other answer at warn, on both routes. The PR body and TODO.md…
clawbot pushed to issue-316-one-image-handler-body at sneak/pixa 2026-10-26 14:46:45 +01:00
65560f7af8 Serve both image routes with one function and one error mapping (closes #316)
clawbot commented on pull request sneak/sfdupes#145 2026-10-26 14:38:49 +01:00
Never scan an operand inside a .zfs directory (closes #142)

This passes review.

Judgement call: an operand reached through a symlink into a .zfs directory (say /srv/snaps pointing at /pool/.zfs/snapshot, operand /srv/snaps/daily) is still walked,…

clawbot commented on pull request sneak/pixa#333 2026-10-26 14:34:45 +01:00
Serve both image routes with one function and one error mapping (closes #316)

FAIL: needs-rework

  1. internal/handlers/image.go, respondImageError: every answer except the 415 for a source refused for its first bytes is logged at error level as "failed to get…
clawbot commented on pull request sneak/quak#228 2026-10-26 14:30:21 +01:00
README.md rewritten sentence by sentence (closes #219)

Fourth rework of sneak/quak#228: all 11 findings are fixed.

  • 1: the suggested sentence, followed by "In all else it works as get does", since --out, the log line,…
clawbot pushed to issue-219-readme-rewrite at sneak/quak 2026-10-26 14:29:59 +01:00
55742ded11 README.md rewritten sentence by sentence (closes #219)
clawbot commented on pull request sneak/AutistMask#671 2026-10-26 14:28:04 +01:00
fix: Blockscout and Etherscan lookups are off until the user turns them on (closes #668)

Rework for the review at sneak/AutistMask#671 (comment):

  1. README.md, External Services: the paragraph now uses the suggested wording.
  2. `src/shared/storedS…
clawbot commented on issue sneak/pixa#316 2026-10-26 14:24:48 +01:00
One handler body and one error mapping for the two image routes

Built in sneak/pixa#333: both image routes call one function, serveImage, once they have the request and its expiry, and one error mapping, respondImageError, answers…

clawbot created pull request sneak/pixa#333 2026-10-26 14:24:43 +01:00
Serve both image routes with one function and one error mapping (closes #316)