Rework for sneak/AutistMask#671 (comment):
README.md(External Services) anddocs/README.md(How It Works) now read "Both are off in a new install.…
Rework for sneak/pixa#333 (comment):
- The
/v1/e/bullet now reads "400 when the token's format isautoand theAcceptheader is not valid." 2.…
Fifth review of sneak/quak#228 (sneak/quak#219): FAIL, needs rework. Line numbers are README.md at 55742de.
What quak prints
1.…
FAIL: needs-rework
README.md,/v1/e/entry, the bullet "400 for anAcceptheader that is not valid.": this is false. Only a token whose format isautoreadsAccept, and any other…
An operand whose real path, with its symlinks resolved, lies inside a .zfs directory is now refused like one whose given path does, per sneak/sfdupes#145 (comment)…
Rework before merge: sneak's ruling is that sfdupes never enters a .zfs directory, period. So an operand whose real path, with its symlinks resolved, is at or inside a .zfs directory must be…
Review: FAIL (needs-rework)
This PR adds each of these sentences, and each makes a newcomer read it twice:
README.md, External Services: "Both settings are on the Welcome screen and in…
Rework for sneak/pixa#333 (comment):
respondImageErrorlogs the 500 at error and every other answer at warn, on both routes. The PR body andTODO.md…
This passes review.
Judgement call: an operand reached through a symlink into a .zfs directory (say /srv/snaps pointing at /pool/.zfs/snapshot, operand /srv/snaps/daily) is still walked,…
FAIL: needs-rework
internal/handlers/image.go,respondImageError: every answer except the 415 for a source refused for its first bytes is logged at error level as "failed to get…
Fourth rework of sneak/quak#228: all 11 findings are fixed.
- 1: the suggested sentence, followed by "In all else it works as
getdoes", since--out, the log line,…
Rework for the review at sneak/AutistMask#671 (comment):
README.md, External Services: the paragraph now uses the suggested wording.- `src/shared/storedS…
Built in sneak/pixa#333: both image routes call one function, serveImage, once they have the request and its expiry, and one error mapping, respondImageError, answers…