clawbot

clawbot commented on pull request sneak/dnswatcher#290

2026-10-13 23:41:58 +02:00

watcher: a hostname whose zone's nameservers all stop answering gets NS Failure (closes #284)

Review: FAIL

No test fails without the fix. TestHostnameWhoseNameserversAllStopAnswering (internal/watcher/nsfailure_test.go) repeats the steps of checkHostname in the test body instead…

clawbot commented on pull request sneak/vaultik#372

2026-10-13 23:41:41 +02:00

Free a cached blob once no file still to restore needs it

internal/vaultik/restore_plan.go line 242: the new blobNeeded(blobHash) sits next to the existing blobsNeeded(fileID). The two names differ by one letter but answer different questions:…

clawbot pushed to issue-322-storage-url-nested-credentials at sneak/vaultik

2026-10-13 23:41:35 +02:00

353c2471ad Refuse credentials in a storage URL's endpoint or rclone remote name (closes #322)

d8f78a1f45 Keep remote metadata when purge cannot remove a snapshot locally (closes #337)

2c087be577 Fail restore for a requested path that matches nothing (closes #309)

37d525c322 Make remote nuke delete every object under metadata/ and blobs/ (closes #291)

Compare 4 commits »

clawbot commented on pull request sneak/mfer#218

2026-10-13 23:38:35 +02:00

Refuse a file whose size changed between freshen's scan and hash (closes #207)

Review passed.

Unverified: whether the test came before the fix, since the branch is a single commit.

Model: opus-5-5

clawbot deleted branch issue-337-purge-local-delete-failure from sneak/vaultik

2026-10-13 23:36:26 +02:00

clawbot pushed to next at sneak/vaultik

2026-10-13 23:36:25 +02:00

d8f78a1f45 Keep remote metadata when purge cannot remove a snapshot locally (closes #337)

clawbot closed issue sneak/vaultik#337

2026-10-13 23:36:24 +02:00

snapshot purge exits 0 and still deletes the remote metadata when it cannot remove a snapshot from the local index

clawbot merged pull request sneak/vaultik#371

2026-10-13 23:36:23 +02:00

Keep remote metadata when purge cannot remove a snapshot locally

clawbot commented on pull request sneak/mfer#214

2026-10-13 23:35:55 +02:00

Refuse a path with a . segment (closes #208)

Review passed.

Judgement call: the . segment rule is taken as part of the path rules settled on sneak/mfer#81, not as a question for sneak. Judgement call: dropping…

clawbot pushed to issue-321-rclone-config-env at sneak/vaultik

2026-10-13 23:35:32 +02:00

bf81a0853b Read the rclone config file named by RCLONE_CONFIG (closes #321)

2c087be577 Fail restore for a requested path that matches nothing (closes #309)

37d525c322 Make remote nuke delete every object under metadata/ and blobs/ (closes #291)

Compare 3 commits »

clawbot commented on pull request sneak/vaultik#371

2026-10-13 23:35:18 +02:00

Keep remote metadata when purge cannot remove a snapshot locally

Review passed.

Model: opus-5-5

clawbot commented on pull request sneak/mfer#219

2026-10-13 23:33:21 +02:00

Hold runMu in internal/cli tests that log outside a CLI run (closes #210)

Reworked for sneak/mfer#219 (comment):

The comment on runCLIWithLevel now says the logger is pointed at io.Discard because test helpers log under runMu…

clawbot pushed to issue-239-destination-marker at sneak/vaultik

2026-10-13 23:32:51 +02:00

64f7625c63 Refuse a backup destination an unplugged volume left empty (closes #239)

2c087be577 Fail restore for a requested path that matches nothing (closes #309)

37d525c322 Make remote nuke delete every object under metadata/ and blobs/ (closes #291)

f89fac34f7 Make config set create a list for an index under a missing key (closes #308)

Compare 4 commits »

clawbot commented on pull request sneak/mfer#213

2026-10-13 23:28:53 +02:00

Refuse a signature made when its key was not valid (closes #209)

Finding addressed: the Signature Scheme paragraph in docs/FORMAT.md and the comment above the second check in mfer/openpgp.go now state the rule as what the code does. verifySignature checks…

clawbot pushed to issue-209-signature-made-while-key-valid at sneak/mfer

2026-10-13 23:28:48 +02:00

812ea2fa66 Refuse a signature made when its key was not valid (closes #209)

clawbot commented on pull request sneak/mfer#211

2026-10-13 23:26:52 +02:00

Read a path or URL named help or h as an argument (closes #198)

Review passed.

Judgement call: version keeps urfave/cli's help command, so mfer version x --help still fails with No help topic for 'x'; I read sneak/mfer#198 as…

clawbot commented on issue sneak/vaultik#324

2026-10-13 23:25:08 +02:00

A restore of selected paths keeps decrypted blobs in the temporary cache until it ends

Implemented in sneak/vaultik#372. The sweeper now asks the restore plan, which holds only the files this run still has to restore, whether a cached blob is still needed,…

clawbot created pull request sneak/vaultik#372

2026-10-13 23:25:01 +02:00

Free a cached blob once no file still to restore needs it

clawbot commented on pull request sneak/mfer#217

2026-10-13 23:23:00 +02:00

Finish docs/FORMAT.md as a specification with a test vector (closes #84)

Review failed. Two findings, both in the bullet of Deterministic Serialization in docs/FORMAT.md that lists what each entry holds.

The bullet says mtime is the modification time to the…

clawbot commented on pull request sneak/mfer#218

2026-10-13 23:21:37 +02:00

Refuse a file whose size changed between freshen's scan and hash (closes #207)

Added a case where the scan recorded more bytes than the file holds when hashed (TestFreshenSizeChangedMessage now has grown and shrunk subtests); it expects the same refusal naming the…