clawbot commented on pull request sneak/vaultik#396 2026-10-15 05:13:07 +02:00
Do not prune when a backup misses an earlier mount point (closes #395)

Rework of the review above:

  1. TestDeviceNumberFromStat (new internal/snapshot/device_number_test.go) runs deviceNumberFromStat on the real filesystem: a temp directory and a file in it…
clawbot pushed to issue-248-chunked-body-at-limit at sneak/pixa 2026-10-15 05:10:20 +02:00
551bed1918 Test a body of exactly the maximum size, chunked or not
clawbot created branch issue-248-chunked-body-at-limit in sneak/pixa 2026-10-15 05:10:20 +02:00
clawbot commented on pull request sneak/pixa#263 2026-10-15 05:09:49 +02:00
Sync cached files and refuse ones left empty or partial (closes #252)

Decision for finding 1, taking the reviewer's first way: no size comparison on the request path. Compare each cached source's and transformed image's file size with its recorded size in the…

clawbot commented on pull request sneak/secret#162 2026-10-15 05:08:13 +02:00
Hold the encrypt and decrypt result in memory until it is written (closes #143)

Rework:

  1. The README, both comments, the commit message and the PR body now say that a failure to encrypt or decrypt leaves --output untouched, and that a failure while writing it, such as a…
clawbot commented on pull request sneak/pixa#263 2026-10-15 05:05:39 +02:00
Sync cached files and refuse ones left empty or partial (closes #252)

Review failed: needs-rework.

  1. internal/imgcache/cache.go, LookupSource: comparing the cached source file's size with its recorded size on every request makes the existing test `TestService…
clawbot pushed to issue-256-logout-ends-sessions at sneak/pixa 2026-10-15 05:03:56 +02:00
7fd9994d4b Logging out ends every login session (closes #256)
clawbot pushed to issue-395-missing-volume-prune at sneak/vaultik 2026-10-15 05:01:24 +02:00
eb5b4f9fdf Do not prune when a backup misses an earlier mount point (closes #395)
clawbot pushed to issue-246-normalize-source-host at sneak/pixa 2026-10-15 04:59:09 +02:00
9dbb3ffe07 Test that the image URL's host is one spelling (part of #246)
clawbot created branch issue-246-normalize-source-host in sneak/pixa 2026-10-15 04:59:08 +02:00
clawbot pushed to fix/158-add-newline-docs at sneak/secret 2026-10-15 04:56:16 +02:00
287f33f386 README says secret add drops one trailing newline and import keeps it (closes #158)
00e34b93ec secret version list no longer shows a version without NOT_AFTER as expired (closes #150)
0ffffd5e3f Print an empty unlocker or vault list as [] in JSON (closes #148)
Compare 3 commits »
clawbot created pull request sneak/pixa#264 2026-10-15 04:55:52 +02:00
Allowlist no host in the example config (closes #249)
clawbot pushed to issue-395-missing-volume-prune at sneak/vaultik 2026-10-15 04:55:20 +02:00
1e1ae8380b Do not prune when a backup misses an earlier mount point (closes #395)
clawbot pushed to fix/183-unknown-subcommand at sneak/secret 2026-10-15 04:54:58 +02:00
7dfa13a76f Unknown subcommands of vault, unlocker, version and generate fail (closes #183)
00e34b93ec secret version list no longer shows a version without NOT_AFTER as expired (closes #150)
0ffffd5e3f Print an empty unlocker or vault list as [] in JSON (closes #148)
Compare 3 commits »
clawbot pushed to fix/140-corrupt-metadata-index at sneak/secret 2026-10-15 04:52:41 +02:00
f55d00225e Stop vault creation when a vault's metadata cannot be read (closes #140)
00e34b93ec secret version list no longer shows a version without NOT_AFTER as expired (closes #150)
0ffffd5e3f Print an empty unlocker or vault list as [] in JSON (closes #148)
Compare 3 commits »
clawbot pushed to fix/159-crossvault-mv-source-removal at sneak/secret 2026-10-15 04:51:30 +02:00
0a35796205 A cross-vault secret mv that cannot remove the source fails (closes #159)
00e34b93ec secret version list no longer shows a version without NOT_AFTER as expired (closes #150)
0ffffd5e3f Print an empty unlocker or vault list as [] in JSON (closes #148)
Compare 3 commits »
clawbot pushed to issue-256-logout-ends-sessions at sneak/pixa 2026-10-15 04:51:02 +02:00
e5d9f64d83 Test that logging out ends a copied login session (part of #256)
clawbot created branch issue-256-logout-ends-sessions in sneak/pixa 2026-10-15 04:51:02 +02:00
clawbot pushed to fix/146-gpg-stderr at sneak/secret 2026-10-15 04:50:43 +02:00
d1f858c303 Include gpg's stderr in the error when gpg fails (closes #146)
00e34b93ec secret version list no longer shows a version without NOT_AFTER as expired (closes #150)
0ffffd5e3f Print an empty unlocker or vault list as [] in JSON (closes #148)
Compare 3 commits »
clawbot pushed to fix/143-atomic-output at sneak/secret 2026-10-15 04:50:19 +02:00
b405224775 Hold the encrypt and decrypt result in memory until it is written (closes #143)
00e34b93ec secret version list no longer shows a version without NOT_AFTER as expired (closes #150)
0ffffd5e3f Print an empty unlocker or vault list as [] in JSON (closes #148)
438c36e7a9 A secret too large for the locked-memory limit fails with an error, not a panic (closes #145)
Compare 4 commits »