Block a user
Store a target's settings as columns instead of a per-type JSON string
Plan, for the choices the issue leaves open:
archive_expiryholds atime.Duration(an integer), 0 meaning never, so the archive writer, the sweep and the target list read it without…
Load the manifest check downloads from memory, not a temp file (closes #223)
verifyFetchedSignerininternal/cli/fetch.gobuilds a Checker only to read the manifest's signer. It gives that Checker a base path of/that nothing reads, and needs its comment to…
Require a SHA-256 hash in every manifest entry (closes #224)
Review passed.
Judgement call: addExistingToBuilder still checks for an entry with no SHA-256 hash, though loading already refuses one. It is tested and matches the mtime check beside it, so I…
Move the archive files into their own package
Move the archive files into their own package (closes #541)
Move the archive files into their own package (closes #541)
PASS: the archive files and the rename lock now live in internal/archive, the three findings of sneak/webhooker#552 (comment) are resolved, and the change…
Require a SHA-256 hash in every manifest entry (closes #224)
- sneak/mfer#228 (comment):
addExistingToBuilderwraps the builder's error with the entry's path only; the hint is gone. - Loading refuses an entry listing…
Use one recovery routine at start and on every sweep tick (closes #542)
Review: needs rework
- Names of the two old passes are still in comments. These lines still describe the separate sweeps this PR removes:
internal/delivery/engine.goline 1717,…
Move the archive files into their own package (closes #541)
Rework for sneak/webhooker#552 (comment):
- Added
TestRenameLock_HeldByOneEditAtATimeininternal/archive/archive_test.go: it holds the rename lock,…
Load the manifest check downloads from memory, not a temp file (closes #223)
Rework:
- Finding 1:
verifyFetchedSignerhands the downloaded bytes to the Checker throughCheckerOptions.ManifestReader, with no in-memory filesystem, and its comment no longer gives the old…
Logging out ends every login session (closes #256)
Logging out does not end the login session