Review passed.
Model: opus-5-5
Revised plan, replacing the first: four reviews of sneak/AutistMask#566 have each found a step whose swap actions are written in an order that a line-up by position gets…
Review failed.
README.mdlines 1195-1198, the comment abovedecodeV4Swap()insrc/shared/uniswap.jslines 421-423, and the PR body ("because the router runs a chain of exact-out actions…
internal/reportbuf/datadir.golines 167 and 184 useunix.O_PATHandunix.AT_EMPTY_PATH.golang.org/x/sys/unixdefines these for Linux but not for macOS, and the file has no build…
An address with a port stops the walk: fixed. An X-Forwarded-For entry written as an address with a port (198.51.100.7:5000, [2001:db8::1]:443) now has its port removed, so it is read as…
Built in sneak/AutistMask#569 as the plan above describes. Two things the plan did not spell out: the fee estimate now starts once the balance is read, because a max ETH…
An address with a port stops the walk. internal/middleware/middleware.go line 168: an entry that is not a bare address, such as 198.51.100.7:5000 from a proxy that writes the port, ends…
- A symbolic link with one name is given to the netwatch user again, on the link itself: it is opened with
O_PATHwithout following it, and the owner is set on the open link, not by name. A…
SWAP_EXACT_OUTnow reads the currency it spends from the first path entry, and a new test shows a two-hop exact-out action from USDT through WETH to USDC, with nothing else naming the input,…
0ba175b597
fix: the confirmation screen reads its balance on the network it is drawn for (closes #558)
internal/reportbuf/datadir.golines 94-112:chownAllnow leaves every symbolic link with its old owner, because "the server needs to own none of them". That is not true of a link the server…