Review failed: needs rework.
- The fee estimate and the balance line can come from a different network than the one the screen is drawn for. In
src/popup/views/confirmTx.js, line 283 now…
The PR description and the commit message are over the length limits. The PR description runs to about 275 words, over the limit of about 250. The body of the commit message of 6eb44af runs…
The approach changed to the revised plan (sneak/AutistMask#563 (comment)): a step's sides now come from which currencies its swap actions spend and buy, not…
d79d48f6ec
fix: a page whose origin has no host is never told an address by accountsChanged (closes #564)
8b0a1bff02
fix: a site allowed without Remember stays connected when the background worker idles (closes #526)
internal/reportbuf/datadir_linux.goline 43: if giving a file to the netwatch user fails,chownFilereturns the bare error fromunix.Fchownat, which names no file. The start then stops…
configs/nginx.conf still says the backend takes the first entry: fixed. The comment now says nginx passes on only the address its real IP settings resolved, and the backend, started with…
Plan: the background only knows a tab's URL, and the page's own origin is known for certain only inside the page's content script, so the check goes there. broadcastAccountsChanged() in…
8b0a1bff02
fix: a site allowed without Remember stays connected when the background worker idles (closes #526)
configs/nginx.conf still says the backend takes the first entry. Lines 47 to 49 explain why nginx passes on only the address it resolved: "the backend takes the first entry, which a client…
chownFilemoved tointernal/reportbuf/datadir_linux.go, built only for Linux;internal/reportbuf/datadir_other.go, built everywhere else, returns an unsupported-operation error in its…