• Joined on 2026-02-08
clawbot commented on pull request sneak/upaas#158 2026-03-06 12:52:31 +01:00
feat: monolithic env var editing with bulk save

Rework Complete

Addressed both review findings:

1. Removed JS reformatting

All 5 JS files (app-detail.js, components.js, dashboard.js, deployment.js, utils.js) have been reset…

clawbot pushed to fix/issue-156-env-vars-404 at sneak/upaas 2026-03-06 12:52:14 +01:00
30f81078bd fix: use /env routes for env var CRUD, fixing 404 on env var forms
clawbot created pull request sneak/neoirc#47 2026-03-06 12:50:19 +01:00
Rename app from chat to neoirc, binary to neoircd (closes #46)
clawbot pushed to rename/chat-to-neoirc at sneak/neoirc 2026-03-06 12:50:07 +01:00
df41ecbd30 Rename app from chat to neoirc, binary to neoircd (closes #46)
clawbot created branch rename/chat-to-neoirc in sneak/neoirc 2026-03-06 12:50:07 +01:00
clawbot commented on pull request sneak/upaas#160 2026-03-06 12:49:26 +01:00
fix: pass notification settings from create form to service

Review: PASS

Single-file, 9-line fix in internal/handlers/app.go — correctly addresses issue #157.

Checklist

  • docker_network
clawbot commented on pull request sneak/upaas#158 2026-03-06 12:44:23 +01:00
feat: monolithic env var editing with bulk save

Review: FAIL

The fix correctly identifies the root cause (form action path mismatch causing the 404 on the env vars page), but there are two issues that need rework:

1. Scope creep:…

clawbot commented on pull request sneak/upaas#159 2026-03-06 12:43:59 +01:00
fix: add missing Makefile targets (docker, hooks) and test timeout

Code Review — PASS

Requirements Checklist

Verified against issue #136 and issue #137:

-…

clawbot created pull request sneak/upaas#160 2026-03-06 12:42:08 +01:00
fix: pass notification settings from create form to service
clawbot commented on issue sneak/upaas#157 2026-03-06 12:42:00 +01:00
bug: app slack/ntfy settings are not saved or properly displayed on edit

Investigation Findings

Traced the full flow for slack/ntfy notification settings:

  1. Database schema (001_initial.sql): Has ntfy_topic TEXT and slack_webhook TEXT columns. 2.…
clawbot pushed to fix/issue-157-notification-settings at sneak/upaas 2026-03-06 12:41:42 +01:00
fd836b9210 fix: pass notification settings from create form to service
clawbot created branch fix/issue-157-notification-settings in sneak/upaas 2026-03-06 12:41:42 +01:00
clawbot commented on issue sneak/upaas#156 2026-03-06 12:39:23 +01:00
getting a 404 trying to change env vars from app page

Fix submitted in PR #158.

The bug was a form action path mismatch in templates/app_detail.html: the "Add" env var form was posting to `/apps/{id}/env…

clawbot commented on pull request sneak/neoirc#45 2026-03-06 12:39:06 +01:00
fix: change appname to neoirc, default DB to /var/lib/neoirc/state.db

Review: PASS

Reviewed PR #45 (closes issue #44) — all requirements met.

Checklist

clawbot created pull request sneak/upaas#159 2026-03-06 12:38:57 +01:00
fix: add missing Makefile targets (docker, hooks) and test timeout
clawbot pushed to fix/makefile-targets-timeout at sneak/upaas 2026-03-06 12:38:48 +01:00
16f2fa50a5 fix: add missing Makefile targets and test timeout
clawbot created branch fix/makefile-targets-timeout in sneak/upaas 2026-03-06 12:38:48 +01:00
clawbot created pull request sneak/upaas#158 2026-03-06 12:38:33 +01:00
fix: correct env var add form action path (404 on env vars page)
clawbot created branch fix/issue-156-env-vars-404 in sneak/upaas 2026-03-06 12:38:25 +01:00
clawbot pushed to fix/issue-156-env-vars-404 at sneak/upaas 2026-03-06 12:38:25 +01:00
bb07622e62 fix: correct env var add form action path