✅ PASS — PR #63 post-rebase review
All checks pass after rebase onto main (which includes PR #71 pkg/irc move):
- Mergeable: true
- **No…
Rebased onto current main (which includes PR #71). Changes:
- Rebase was clean — no conflicts. PR #71 already moved the IRC module to
pkg/irc/and…
Rebased feat/hashcash-pow onto current main (which now includes PR #71 — IRC module move to pkg/irc/). Resolved merge conflict in `cmd/neoirc-cli/m…
Review: ✅ PASS
Reviewing latest commit df6aad9 (refactor: POST env vars as JSON array instead of KEY=value string). This is the round 3 rework addressing sneak's feedback to stop building a…
Audit: Removed merge-ready. This PR was created and reviewed by clawbot — self-review violation. sneak's feedback ("you are not allowed to touch os.Stderr") was reportedly addressed, but no…
Audit: Removed merge-ready. This PR has no formal code review on record. sneak provided feedback (streaming instead of buffering) which was addressed, but no independent review was…
Audit: Removed merge-ready. This PR was created by clawbot and reviewed by clawbot — self-review is forbidden per SDLC policy. No CI has ever run on this branch. Needs independent review.…
Audit: Removed merge-ready. CI is failing on this PR (check run returned failure). Must fix CI before this can be reviewed. Set needs-rework.
Reworked per feedback. Changes:
Frontend: envVarEditor.submitAll() now uses fetch() to POST a JSON array of {"key": ..., "value": ...} objects to /apps/{id}/env with `Content-Type:…
Review: ✅ PASS
Reviewing the latest commit 3f96f4f (fix: match original table UI with immediate per-action submission). This is the final rework after the previous PASS at comment #12807…
Rework complete — restored the original table-based env var UI to match the main branch layout:
- Per-row Edit/Delete buttons with the same CSS classes and visual appearance as before -…
Review: ✅ PASS
The monolithic env var editing rework is clean, correct, and well-tested.
What changed
- Routes: Three individual env var CRUD routes consolidated into a single `POST…
Reworked per feedback. Key changes:
- Restored table-based UI — The env vars section now shows the original table layout with key/value columns, inline edit, and delete buttons. No more…
Implementation Summary
This PR adds retry with exponential backoff for all notification endpoints, addressing issue #62.