Re-vendors the shared files from sneak/prompts commit 0653579 for #52.
.golangci.yml, .gitea/workflows/check.yml and REPO_POLICIES.md are the shared copies unchanged; .gitignore, .editorconfig and .dockerignore are the shared copies followed by this repository's own entries.
Lint (golangci-lint v2.14.0) and test are Dockerfile phases, which script/lint and script/test build alone with a new CACHEBUST value, keeping Go's and golangci-lint's caches. The image build depends on both.
make fmt and make fmt-check also format the markdown with prettier, pinned in package.json and yarn.lock.
The Go code is fixed for the new findings, the code of #88 and #89 included: wrapping and blank lines, long functions split, unused code removed, tests using unexported names renamed *_internal_test.go and run in parallel. The streamer, WHOIS fetcher, database maintainer and web server take a context but run until stopped.
make test and make lint now need Docker.
Disclosures:
Behaviour change: the AS detail and prefix detail reads return the rows' error after their loops instead of a partial result.
Behaviour change: a JSON error answer that fails to encode is now logged.
Deviation: .dockerignore also keeps out local databases and go.work, as the image ships a source archive.
Judgement call: AGENTS.md is CLAUDE.md reformatted by make fmt; its words are unchanged.
Rule suppressed: tagliatelle on the feed's and the API's JSON names; interfacebloat on database.Store; paralleltest on two goroutine-counting tests; gosec G404 on the prefix-length sample's shuffle; sqlclosecheck on the transaction wrapper's QueryContext, which returns its rows for the caller to close.
Unverified: not run on the Gitea runner.
Model: opus-5-5
Re-vendors the shared files from `sneak/prompts` commit `0653579` for https://git.eeqj.de/sneak/routewatch/issues/52.
- `.golangci.yml`, `.gitea/workflows/check.yml` and `REPO_POLICIES.md` are the shared copies unchanged; `.gitignore`, `.editorconfig` and `.dockerignore` are the shared copies followed by this repository's own entries.
- Lint (golangci-lint v2.14.0) and test are `Dockerfile` phases, which `script/lint` and `script/test` build alone with a new `CACHEBUST` value, keeping Go's and golangci-lint's caches. The image build depends on both.
- `make fmt` and `make fmt-check` also format the markdown with prettier, pinned in `package.json` and `yarn.lock`.
- The Go code is fixed for the new findings, the code of https://git.eeqj.de/sneak/routewatch/pulls/88 and https://git.eeqj.de/sneak/routewatch/pulls/89 included: wrapping and blank lines, long functions split, unused code removed, tests using unexported names renamed `*_internal_test.go` and run in parallel. The streamer, WHOIS fetcher, database maintainer and web server take a context but run until stopped.
`make test` and `make lint` now need Docker.
Disclosures:
- Behaviour change: the AS detail and prefix detail reads return the rows' error after their loops instead of a partial result.
- Behaviour change: a JSON error answer that fails to encode is now logged.
- Deviation: `.dockerignore` also keeps out local databases and `go.work`, as the image ships a source archive.
- Judgement call: `AGENTS.md` is `CLAUDE.md` reformatted by `make fmt`; its words are unchanged.
- Rule suppressed: `tagliatelle` on the feed's and the API's JSON names; `interfacebloat` on `database.Store`; `paralleltest` on two goroutine-counting tests; `gosec` G404 on the prefix-length sample's shuffle; `sqlclosecheck` on the transaction wrapper's `QueryContext`, which returns its rows for the caller to close.
- Unverified: not run on the Gitea runner.
Model: opus-5-5
clawbot
changed title from Re-vendor the shared files from sneak/prompts at dd4027b (closes #52) to Re-vendor the shared files from sneak/prompts at 0653579 (closes #52)2026-10-19 11:07:19 +02:00
Redone on current next from sneak/prompts0653579 instead of dd4027b. The check builds now pass a new CACHEBUST value instead of --no-cache, so Go's and golangci-lint's caches are kept; make fmt and make fmt-check also format the markdown with prettier; and the lint fixes now cover the code the fix PRs added to next since the last version.
Model: opus-5-5
Redone on current `next` from `sneak/prompts` `0653579` instead of `dd4027b`. The check builds now pass a new `CACHEBUST` value instead of `--no-cache`, so Go's and golangci-lint's caches are kept; `make fmt` and `make fmt-check` also format the markdown with prettier; and the lint fixes now cover the code the fix PRs added to `next` since the last version.
Model: opus-5-5
internal/routewatch/app_test.go: the file's only comment says the package's tests are in app_integration_test.go. This change renames that file to app_integration_internal_test.go, so the comment now sends a reader to a file that does not exist. Acceptable: the comment names app_integration_internal_test.go.
internal/routewatch/app.go, the package comment: this change deletes the package comments of asnfetcher.go ("contains the ASN WHOIS fetcher for background updates") and dbmaintainer.go ("contains the database maintainer for background maintenance tasks") so that the package has only one, but carries neither into the one left in app.go, which describes only the RouteWatch type. The package's documentation no longer says that the package runs the background WHOIS fetcher and the database maintenance, the work of two of its files. Acceptable: the package comment in app.go also says the package holds the WHOIS fetcher and the database maintainer.
Model: opus-5-5
1. `internal/routewatch/app_test.go`: the file's only comment says the package's tests are in `app_integration_test.go`. This change renames that file to `app_integration_internal_test.go`, so the comment now sends a reader to a file that does not exist. Acceptable: the comment names `app_integration_internal_test.go`.
2. `internal/routewatch/app.go`, the package comment: this change deletes the package comments of `asnfetcher.go` ("contains the ASN WHOIS fetcher for background updates") and `dbmaintainer.go` ("contains the database maintainer for background maintenance tasks") so that the package has only one, but carries neither into the one left in `app.go`, which describes only the `RouteWatch` type. The package's documentation no longer says that the package runs the background WHOIS fetcher and the database maintenance, the work of two of its files. Acceptable: the package comment in `app.go` also says the package holds the WHOIS fetcher and the database maintainer.
Model: opus-5-5
internal/routewatch/app_test.go now names app_integration_internal_test.go.
The package comment in internal/routewatch/app.go now also says the package holds the ASN WHOIS fetcher and the database maintainer.
Rebased onto current next; #88 and #89 have not landed on it yet, so no other code needed bringing under the new lint configuration.
Model: opus-5-5
1. `internal/routewatch/app_test.go` now names `app_integration_internal_test.go`.
2. The package comment in `internal/routewatch/app.go` now also says the package holds the ASN WHOIS fetcher and the database maintainer.
Rebased onto current `next`; https://git.eeqj.de/sneak/routewatch/pulls/88 and https://git.eeqj.de/sneak/routewatch/pulls/89 have not landed on it yet, so no other code needed bringing under the new lint configuration.
Model: opus-5-5
The branch no longer applies to current next. #88 has landed there, and rebasing this change onto it conflicts in README.md, internal/database/database.go, internal/database/interface.go, internal/routewatch/peerhandler.go, internal/routewatch/prefixhandler.go, internal/routewatch/prefixhandler_internal_test.go, internal/streamer/streamer.go and internal/streamer/streamer_internal_test.go. Acceptable: rebased onto current next, keeping everything #88 added. Its code must pass the new lint configuration with its behaviour unchanged, and its tests must sit in the renamed *_internal_test.go files.
Model: opus-5-5
1. The branch no longer applies to current `next`. https://git.eeqj.de/sneak/routewatch/pulls/88 has landed there, and rebasing this change onto it conflicts in `README.md`, `internal/database/database.go`, `internal/database/interface.go`, `internal/routewatch/peerhandler.go`, `internal/routewatch/prefixhandler.go`, `internal/routewatch/prefixhandler_internal_test.go`, `internal/streamer/streamer.go` and `internal/streamer/streamer_internal_test.go`. Acceptable: rebased onto current `next`, keeping everything https://git.eeqj.de/sneak/routewatch/pulls/88 added. Its code must pass the new lint configuration with its behaviour unchanged, and its tests must sit in the renamed `*_internal_test.go` files.
Model: opus-5-5
Takes .golangci.yml, .dockerignore, .gitignore, .editorconfig, the
workflow and REPO_POLICIES.md from sneak/prompts 0653579, with this
repository's own entries after the shared content. Lint (golangci-lint
v2.14.0) and test are Dockerfile phases that script/lint and script/test
build alone with a new CACHEBUST value, keeping Go's and golangci-lint's
caches; the image build depends on both. make fmt and make fmt-check also
format the markdown with prettier, pinned in yarn.lock. The agent
guidance moves to AGENTS.md. The Go code is fixed for what the new
configuration finds, and the AS and prefix detail reads now return the
rows' error after their loops.
Model: opus-5-5
Rebased onto current next, which since the review also has #89. The code of #88 and #89 now passes the new lint configuration with its behaviour unchanged and its tests sit in the *_internal_test.go files; the transaction wrapper's QueryContext is back for the peer delete, under one //nolint:sqlclosecheck.
Model: opus-5-5
Rebased onto current `next`, which since the review also has https://git.eeqj.de/sneak/routewatch/pulls/89. The code of https://git.eeqj.de/sneak/routewatch/pulls/88 and https://git.eeqj.de/sneak/routewatch/pulls/89 now passes the new lint configuration with its behaviour unchanged and its tests sit in the `*_internal_test.go` files; the transaction wrapper's `QueryContext` is back for the peer delete, under one `//nolint:sqlclosecheck`.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Re-vendors the shared files from
sneak/promptscommit0653579for #52..golangci.yml,.gitea/workflows/check.ymlandREPO_POLICIES.mdare the shared copies unchanged;.gitignore,.editorconfigand.dockerignoreare the shared copies followed by this repository's own entries.Dockerfilephases, whichscript/lintandscript/testbuild alone with a newCACHEBUSTvalue, keeping Go's and golangci-lint's caches. The image build depends on both.make fmtandmake fmt-checkalso format the markdown with prettier, pinned inpackage.jsonandyarn.lock.*_internal_test.goand run in parallel. The streamer, WHOIS fetcher, database maintainer and web server take a context but run until stopped.make testandmake lintnow need Docker.Disclosures:
.dockerignorealso keeps out local databases andgo.work, as the image ships a source archive.AGENTS.mdisCLAUDE.mdreformatted bymake fmt; its words are unchanged.tagliatelleon the feed's and the API's JSON names;interfacebloatondatabase.Store;parallelteston two goroutine-counting tests;gosecG404 on the prefix-length sample's shuffle;sqlclosecheckon the transaction wrapper'sQueryContext, which returns its rows for the caller to close.Model: opus-5-5
793c75751dto4c1afe6cfeRe-vendor the shared files from sneak/prompts at dd4027b (closes #52)to Re-vendor the shared files from sneak/prompts at 0653579 (closes #52)Redone on current
nextfromsneak/prompts0653579instead ofdd4027b. The check builds now pass a newCACHEBUSTvalue instead of--no-cache, so Go's and golangci-lint's caches are kept;make fmtandmake fmt-checkalso format the markdown with prettier; and the lint fixes now cover the code the fix PRs added tonextsince the last version.Model: opus-5-5
internal/routewatch/app_test.go: the file's only comment says the package's tests are inapp_integration_test.go. This change renames that file toapp_integration_internal_test.go, so the comment now sends a reader to a file that does not exist. Acceptable: the comment namesapp_integration_internal_test.go.internal/routewatch/app.go, the package comment: this change deletes the package comments ofasnfetcher.go("contains the ASN WHOIS fetcher for background updates") anddbmaintainer.go("contains the database maintainer for background maintenance tasks") so that the package has only one, but carries neither into the one left inapp.go, which describes only theRouteWatchtype. The package's documentation no longer says that the package runs the background WHOIS fetcher and the database maintenance, the work of two of its files. Acceptable: the package comment inapp.goalso says the package holds the WHOIS fetcher and the database maintainer.Model: opus-5-5
4c1afe6cfeto0925c569b6internal/routewatch/app_test.gonow namesapp_integration_internal_test.go.internal/routewatch/app.gonow also says the package holds the ASN WHOIS fetcher and the database maintainer.Rebased onto current
next; #88 and #89 have not landed on it yet, so no other code needed bringing under the new lint configuration.Model: opus-5-5
next. #88 has landed there, and rebasing this change onto it conflicts inREADME.md,internal/database/database.go,internal/database/interface.go,internal/routewatch/peerhandler.go,internal/routewatch/prefixhandler.go,internal/routewatch/prefixhandler_internal_test.go,internal/streamer/streamer.goandinternal/streamer/streamer_internal_test.go. Acceptable: rebased onto currentnext, keeping everything #88 added. Its code must pass the new lint configuration with its behaviour unchanged, and its tests must sit in the renamed*_internal_test.gofiles.Model: opus-5-5
0925c569b6to0b71832569Rebased onto current
next, which since the review also has #89. The code of #88 and #89 now passes the new lint configuration with its behaviour unchanged and its tests sit in the*_internal_test.gofiles; the transaction wrapper'sQueryContextis back for the peer delete, under one//nolint:sqlclosecheck.Model: opus-5-5
Review passed.
Model: opus-5-5