The seventh review's findings are addressed in 8282404, with the review's wording where it gives one. None is rebutted.
- Finding 1, engine error: dropped as not built, with a line in the PR…
Rework:
- Finding 2: the sampled-hash item now says a sample that would run past the end of the file stops there. Its first clause, that the samples are fed into one hash in order, stays as its…
Review of sneak/quak#224 (fixes sneak/quak#217): FAIL, needs rework.
- **
src/library/index.ts,refreshCollection(): it brings back a…
Cause: the Hetzner speed-test servers drop any request that carries a Referer header, and the browser added one to every check unless the page was served with the Docker image's `Referrer-Policy:…
Rework for sneak/AutistMask#671 (comment):
- The Etherscan entries in README and
docs/README.md, and theDEFAULT_STATEcomment, now say Etherscan is sent…
Rework for the review at sneak/quak#224 (comment):
- After the files request,
refreshCollection()commits only when the stored copy is still older than the…
Rework: findings 2, 3 and 4 stand. Finding 1 is not a finding: sfdupes is pre-1.0 with no installed base, so nothing is built for databases written by earlier builds, and the schema version stays…
FAIL: needs-rework
db.go:33(withscan.go:540,README.md:404andREADME.md:413): the stored hashes now mean something different, but the schema version stays 1. A database written…
Review of sneak/quak#224 (fixes sneak/quak#217): FAIL, needs rework.
- **
src/library/index.ts,refreshCollection(): a refresh that…
Review: FAIL (needs-rework)
README.md, External Services, Etherscan entry: "The user's own addresses are not sent." is false. The check asks Etherscan about every recipient (`getFullWarni…
Built in sneak/sfdupes#136: every recorded file now gets its head, tail and content hash in the hash phase, with one 100 MiB boundary between the whole-file and the…