PASS: this change fixes the five findings of the first review and meets the definition of done of sneak/pixa#311.
- Judgement call: the middleware still reaches…
Rework for sneak/AutistMask#671 (comment):
- TxApproval and SignApproval now show "This token was not looked up on Blockscout, because "Use Blockscout" is off…
Review: PASS.
Model: opus-5-5
Reworked against sneak/sfdupes#141 (comment): one amended commit, rebased onto current next.
- "the content phase's displays for its checks and its reads…
Reworked against sneak/sfdupes#140 (comment): one amended commit, rebased onto current next.
False statements (1 to 2): both lists of what scan prints…
Reworked per sneak/pixa#328 (comment), now at 018c12a:
- The counters are fields of the cache, made in
NewCacheand registered on the registry it is…
FAIL: needs-rework
internal/imgcache/counters.go, and the seven tests marked//nolint:paralleltest. The counters are package-level variables. That needs onegochecknoglobals…
Rework of the review in sneak/quak#226 (comment), against the revised sneak/quak#222:
README.md, "CLI surface": now says they…
FAIL: needs-rework. Line numbers refer to TODO.md at the PR head.
- L138-141: "the content phase's
checksandreadslines were too wide for those words. That held at most elapsed times…
FAIL: needs-rework. Line numbers refer to README.md at the PR head.
False statements
- L122-123 and L524: "a line for each path the walk leaves out on purpose". L377-382 counts a…
Built in sneak/pixa#328. The five counts are Prometheus counters in memory, in internal/imgcache/counters.go, on the registry /metrics serves. cache_stats,…