Block a user
Fetch the source path and query URL-encoded, not joined as text (closes #288)
Decisions: findings 1 to 3 as the reviewer states them; for finding 2, percent-encode ' as well, so the claim stays true. One more case under item 2 of the definition of done in https://git.eeqj.…
A size with one side 0 whose computed side rounds down to 0 comes out square, can ask for tens of GB, or answers 500
Plan: in targetDimensions, the side worked out from the source's proportions for a size with one side 0 is at least 1, whatever the fit. contain and inside then work out both sides again…
A network failure is printed and recorded with its reason (closes #196)
Reworked against sneak/quak#203 (comment), on current next:
- The README paragraph under "Exit codes" now says its wording and example are for quak under…
Fetch the source path and query URL-encoded, not joined as text (closes #288)
Review failed: needs-rework.
internal/handlers/auth.go,HandleGenerateURL: the new check compares the URL pixa would fetch withparsed.RequestURI(), which is not always the source URL as…
An album whose folder cannot be made no longer stops the backup (closes #197)
Finding 1 of sneak/quak#204 (comment): added a test to test/cli/backup.test.ts that backs up the title a. + 300 letters + -x. It checks that the link is…
The binary
make install builds does not retry a connection that fails, or record it as transient
A thin source requested with fit=cover makes libvips allocate a huge uncropped image
Crop the centre before resizing for fit=cover (closes #282)
An album whose folder cannot be made no longer stops the backup (closes #197)
src/backup.ts,uniqueNames: no test reaches the branch inwithIDthat cuts a link name short as a whole when its extension alone leaves no room for(ID). A change that breaks it would…
fix: a slow answer to an approval still reaches the site (closes #540)
- Every approval is now added through
addPendingApproval()insrc/background/index.js, which also starts the timer; the four request functions call it instead of writing topendingApprovals…
A state_dir holding %, ? or # breaks the database URL pixa derives from it
fix: a V4 swap action not in the deployed shape is shown as not decoded (closes #358)
FAIL (needs-rework)
The findings of the three earlier reviews stay resolved.
src/popup/views/approval.js, the new check inshowTxApproval()(lines 301 to 312). For a swap paid in…
A network failure is printed and recorded with its reason (closes #196)
- README, the new paragraph under "Exit codes": the example
quak: fetch failed: connect ECONNREFUSED 1.2.3.4:443is what quak prints when it runs under Node. The~/bin/quakthat `make…