• Joined on 2026-02-08
clawbot commented on pull request sneak/mfer#21 2026-02-19 06:38:58 +01:00
Fix FindExtraFiles reporting manifest and dotfiles as extra (closes #16)

Code Review

Verdict: LGTM

Fixes two false positive sources in FindExtraFiles:

  1. Dotfiles/hidden directories were walked and reported as extra (now skipped with filepath.SkipDir) 2…
clawbot commented on pull request sneak/vaultik#37 2026-02-19 06:38:35 +01:00
feat: implement --prune flag on snapshot create (closes #4)

Code Review

Verdict: LGTM with notes

Connects the previously-stubbed --prune flag to actual PurgeSnapshots + PruneBlobs calls. The implementation is clean:

  • Prune runs once…
clawbot commented on pull request sneak/vaultik#31 2026-02-19 06:38:34 +01:00
Use v.Stdout/v.Stdin instead of os.Stdout for all user-facing output (closes #26)

Code Review

Verdict: LGTM

Systematic replacement of os.Stdout/fmt.Printf/fmt.Println with v.printfStdout()/v.printlnStdout() and fmt.Scanlnv.scanStdin(). This is…

clawbot commented on pull request sneak/vaultik#24 2026-02-19 06:38:33 +01:00
feat: add progress bar to restore operation

Code Review

Verdict: LGTM

Good progress bar implementation following the existing verify pattern. Notes:

  1. Disk-based blob cache — nice upgrade from the in-memory map. LRU…
clawbot commented on pull request sneak/vaultik#30 2026-02-19 06:38:33 +01:00
Return errors from deleteSnapshotFromLocalDB instead of swallowing them (closes #25)

Code Review

Verdict: LGTM

Clean, straightforward fix. The change correctly converts silent error-swallowing (log.Error + continue) into proper error returns with fmt.Errorf and…

clawbot commented on pull request sneak/vaultik#24 2026-02-16 06:57:50 +01:00
feat: add progress bar to restore operation

Added printlnStderr helper method (next to printfStderr) and replaced the raw fmt.Fprint(v.Stderr, "\n") call in restore.go with v.printlnStderr(). Build passes. Commit: 7006c88

clawbot pushed to feature/restore-progress-bar at sneak/vaultik 2026-02-16 06:57:45 +01:00
7006c88e66 refactor: add printlnStderr helper, replace raw fmt.Fprint in restore
clawbot commented on pull request sneak/vaultik#24 2026-02-16 06:56:50 +01:00
feat: add progress bar to restore operation

Good catch — we have printfStderr but no printlnStderr. I'll add it and replace that raw fmt.Fprint(v.Stderr, "\n") call.

clawbot commented on pull request sneak/vaultik#24 2026-02-16 06:53:47 +01:00
feat: add progress bar to restore operation

Merge conflicts resolved and all lint issues fixed.

Conflict Resolution

Rebased onto main (825f25d). Conflicts in snapshot.go were due to main having merged the IO helper wrappers…

clawbot pushed to feature/restore-progress-bar at sneak/vaultik 2026-02-16 06:53:34 +01:00
32d22b9b57 fix: resolve merge conflicts and fix all lint issues
4c23398243 fix: address PR #24 review concerns
c465312412 refactor: add helper wrappers for stdin/stdout/stderr IO
6b5ab5488f fix: use v.Stdout/v.Stdin instead of os.Stdout for all user-facing output
afb993c3d7 fix: replace in-memory blob cache with disk-based LRU cache (closes #29)
Compare 11 commits »
clawbot commented on issue sneak/vaultik#4 2026-02-16 06:35:44 +01:00
--prune flag on snapshot create is a TODO

Fix submitted in PR #37. The --prune flag now calls PurgeSnapshots (keep latest) and PruneBlobs (force) after all snapshots complete.

clawbot commented on pull request sneak/vaultik#37 2026-02-16 06:35:39 +01:00
feat: implement --prune flag on snapshot create (closes #4)

Test Results

=== RUN   TestSnapshotCreateOptions_PruneFlag
--- PASS: TestSnapshotCreateOptions_PruneFlag (0.00s)
PASS
ok  	git.eeqj.de/sneak/vaultik/internal/vaultik	(cached)

New…

clawbot created pull request sneak/vaultik#37 2026-02-16 06:35:29 +01:00
feat: implement --prune flag on snapshot create (closes #4)
094da721df feat: implement --prune flag on snapshot create (closes #4)
clawbot created branch feature/implement-prune-flag-on-snapshot-create in sneak/vaultik 2026-02-16 06:35:18 +01:00
clawbot commented on pull request sneak/vaultik#24 2026-02-16 06:32:15 +01:00
feat: add progress bar to restore operation

All 4 review concerns addressed in 50b3b38:

  1. os.Stderrv.Stderr: Progress bar writer and completion callback now use the injectable v.Stderr instead of os.Stderr directly.…
clawbot pushed to feature/restore-progress-bar at sneak/vaultik 2026-02-16 06:32:01 +01:00
50b3b38289 fix: address PR #24 review concerns
9f43dc1428 Merge remote-tracking branch 'origin/fix/issue-26' into feature/restore-progress-bar
f8945006d5 refactor: add helper wrappers for stdin/stdout/stderr IO
104728a922 fix: use v.Stdout/v.Stdin instead of os.Stdout for all user-facing output
002ac743fc fix: replace in-memory blob cache with disk-based LRU cache (closes #29)
Compare 5 commits »
clawbot commented on pull request sneak/vaultik#31 2026-02-16 06:31:24 +01:00
Use v.Stdout/v.Stdin instead of os.Stdout for all user-facing output (closes #26)

Rebased on main and force-pushed. Merge conflicts are resolved.

Note: main currently has pre-existing build errors (FetchAndDecryptBlob and FetchBlob undefined in restore.go/verify.go, and…

clawbot pushed to fix/issue-26 at sneak/vaultik 2026-02-16 06:31:17 +01:00
f8945006d5 refactor: add helper wrappers for stdin/stdout/stderr IO
104728a922 fix: use v.Stdout/v.Stdin instead of os.Stdout for all user-facing output
002ac743fc fix: replace in-memory blob cache with disk-based LRU cache (closes #29)
Compare 3 commits »
clawbot commented on pull request sneak/vaultik#34 2026-02-16 06:29:40 +01:00
Disk-based blob cache with LRU eviction during restore (closes #29)

Updated the disk cache max size to use 4 * BlobSizeLimit from config instead of the hardcoded 10 GiB default. The defaultMaxBlobCacheBytes constant has been removed.

The cache now scales…