Code Review
Verdict: LGTM ✅
Fixes two false positive sources in FindExtraFiles:
- Dotfiles/hidden directories were walked and reported as extra (now skipped with
filepath.SkipDir) 2…
Code Review
Verdict: LGTM with notes ✅
Connects the previously-stubbed --prune flag to actual PurgeSnapshots + PruneBlobs calls. The implementation is clean:
- Prune runs once…
Code Review
Verdict: LGTM ✅
Systematic replacement of os.Stdout/fmt.Printf/fmt.Println with v.printfStdout()/v.printlnStdout() and fmt.Scanln → v.scanStdin(). This is…
Code Review
Verdict: LGTM ✅
Good progress bar implementation following the existing verify pattern. Notes:
- Disk-based blob cache — nice upgrade from the in-memory map. LRU…
Code Review
Verdict: LGTM ✅
Clean, straightforward fix. The change correctly converts silent error-swallowing (log.Error + continue) into proper error returns with fmt.Errorf and…
Added printlnStderr helper method (next to printfStderr) and replaced the raw fmt.Fprint(v.Stderr, "\n") call in restore.go with v.printlnStderr(). Build passes. Commit: 7006c88
Good catch — we have printfStderr but no printlnStderr. I'll add it and replace that raw fmt.Fprint(v.Stderr, "\n") call.
Merge conflicts resolved and all lint issues fixed.
Conflict Resolution
Rebased onto main (825f25d). Conflicts in snapshot.go were due to main having merged the IO helper wrappers…
Fix submitted in PR #37. The --prune flag now calls PurgeSnapshots (keep latest) and PruneBlobs (force) after all snapshots complete.
Test Results
=== RUN TestSnapshotCreateOptions_PruneFlag
--- PASS: TestSnapshotCreateOptions_PruneFlag (0.00s)
PASS
ok git.eeqj.de/sneak/vaultik/internal/vaultik (cached)
✅ New…
All 4 review concerns addressed in 50b3b38:
os.Stderr→v.Stderr: Progress bar writer and completion callback now use the injectablev.Stderrinstead ofos.Stderrdirectly.…
Rebased on main and force-pushed. Merge conflicts are resolved.
Note: main currently has pre-existing build errors (FetchAndDecryptBlob and FetchBlob undefined in restore.go/verify.go, and…
Updated the disk cache max size to use 4 * BlobSizeLimit from config instead of the hardcoded 10 GiB default. The defaultMaxBlobCacheBytes constant has been removed.
The cache now scales…