Code Review: LGTM ✅
Adds a progress bar (via progressbar lib) to the restore operation showing bytes restored.
- Calculates total expected bytes upfront, creates terminal-aware progress…
Added Go-specific coding policies to AGENTS.md as requested:
- No
panic/log.Fatal/os.Exitin library code — always return errors - Constructors return
(*T, error), not just*T3.…
Fixed. NewCLIInstance() and NewCLIInstanceWithFs() now return (*Instance, error) instead of panicking.
- RunE callers propagate the error via
return fmt.Errorf(...) - Command construction…
Code Review: LGTM ✅
Clean, minimal change that correctly tracks and reports file restore failures.
- Increments
result.FilesFailedand appends toresult.FailedFileswhenrestoreFile…
Fixed both review points:
- No peer certs → error:
extractCertInfonow returns(nil, ErrNoPeerCertificates)instead of an empty struct. New sentinel errorErrNoPeerCertificates…
Good catch — the panic in NewCLIInstance/NewCLIInstanceWithFs is there because these constructors return *Instance (no error return), so the error had nowhere to go. The t.Fatalf in…
make check audit result
✅ All checks passed.
==> Checking formatting...
==> Running linter...
0 issues.
==> Running tests...
--- PASS: TestNSChangeDetection (0.00s)
--- PASS:…
make check audit result
✅ All checks passed.
==> Checking formatting...
==> Running linter...
0 issues.
==> Running tests...
--- PASS: TestCheckCertificateContextCanceled (0.00s)
---…
make check audit result
✅ All checks passed.
==> Checking formatting...
==> Running linter...
golangci-lint run --config .golangci.yml ./...
0 issues.
==> Running tests...
go test -v…
✅ make check passes cleanly (0 lint issues, all tests pass). Rebased on main. Fixed: gosec G204 suppression (pre-existing), updated integration test to accept uppercase secret names (was…
✅ make check passes cleanly (0 lint issues, all tests pass). Rebased on main. Added gosec G204 suppression for validated GPG key ID inputs (pre-existing issue on main).
✅ make check passes cleanly (0 lint issues, all tests pass). Rebased on main. Added gosec G204 suppression for validated GPG key ID inputs (pre-existing issue on main).
✅ make check passes cleanly (0 lint issues, all tests pass). Rebased on main. Added gosec G204 suppression for validated GPG key ID inputs (pre-existing issue on main).
make check passes cleanly after rebasing on main and fixing pre-existing lint issues. All tests pass, linter clean, build succeeds.
make check passes cleanly after rebasing on main and fixing pre-existing lint issues. All tests pass, linter clean, build succeeds.