Block a user
fix: the address screen shows a token just added at its fetched balance, not 0.0000 (closes #516)
- The separate list is gone: the mark is now
balanceNotFetchedon the tracked token's own record, so removing the token removes it and an add cannot list it twice. A new test removes a token…
Never move last seen back or first seen forward (closes #162)
- Fixed: the batch writes in the test give
Firstan hour beforeLast, so the test fails if the two are swapped in the update calls ofGetOrCreateASNBatch,RecordPeeringor `UpdatePeerBatch…
Answer 499 to a client that goes away while waiting for an image (closes #339)
- In the second commit, the 499 bullet under
/v1/image/inREADME.mdnow reads "499, with no body, when the client goes away before its image is ready, unless its request is the one making…
Answer 499 to a client that goes away while waiting for an image (closes #339)
FAIL: needs-rework
README.mdline 382, after the routes list, says: "The image routes answer the errors listed for them with JSON holdingerror,statusandtimestamp." The change…
Closing a transaction or signature approval window leaves the request pending (closes #673)
Review: FAIL (needs-rework)
src/background/index.js, the comment overTX_APPROVAL_PENDING_MESSAGE(lines 163–166): "the other request is either being prepared or on screen" is now…
Never move last seen back or first seen forward (closes #162)
FAIL: needs-rework
internal/database/database_internal_test.go, lines 1993, 2004 and 2012 (TestOlderWriteKeepsLastSeenAndLowersFirstSeen). Every batch write passes the same time as…
Answer 499 to a client that goes away while waiting for an image (closes #339)
- In the second commit,
README.md, the doc comment ofstatusClientClosedRequestand theTODO.mdentry now give 499 when the client goes away before its image is ready, unless its request is…
Answer 499 to a client that goes away while waiting for an image (closes #339)
FAIL: needs-rework
- Four places say 499 goes only to a client that leaves while its request waits for an image another request is making:
README.mdline 313- the doc comment of…
First seen can be later than last seen when a collector sends old updates
sneak/routewatch#170 makes every update to a stored AS, peering or peer keep the earlier first-seen time and the later last-seen time. The rule is in the SQL, and the…
Never move last seen back or first seen forward (closes #162)
Rewrite README.md sentence by sentence for a newcomer
FAIL: needs-rework. Line numbers refer to README.md at the PR head.
False statements
- L479-483, "Rules for the walk": "With
-x, it never enters a directory on a different…
Answer 499 to a client that goes away while waiting for an image (closes #339)
- In the first commit, the test is now
TestImageRoutes_ClientGoneWhileWaitingAnswers499, and its doc comment names only a request whose client goes away while it waits for an image another…