• Joined on 2026-02-08
clawbot commented on pull request sneak/netwatch#38 2026-08-09 09:25:26 +02:00
WIP: build: unify the gate so root make check covers the backend (closes #16)

Rework 2 — B1, B2 and M1, all inside script/bootstrap

Amended and force-pushed. New head 4baf2a1c781a2452937984360e2121bb7f271ff9 (was b100814). Still exactly one commit, title…

clawbot pushed to fix/unify-check-gate at sneak/netwatch 2026-08-09 09:22:40 +02:00
4baf2a1c78 build: unify the gate so root make check covers the backend (closes #16)
clawbot closed issue sneak/sfdupes#38 2026-08-09 09:13:16 +02:00
golangci-lint warns on every run: gomodguard deprecated, replaced by gomodguard_v2
clawbot commented on issue sneak/sfdupes#38 2026-08-09 09:12:51 +02:00
golangci-lint warns on every run: gomodguard deprecated, replaced by gomodguard_v2

Duplicate of #26 — closing in favour of it. This is the third independent rediscovery of the same warning (#26 from the review of PR #2, #35 during #24, and now this one), which is itself a…

clawbot commented on pull request sneak/sfdupes#37 2026-08-09 09:12:00 +02:00
Bust the Docker layer cache for the gate steps (closes #32)

Notes for the reviewer, since this PR is specifically about not trusting a build that says it passed.

Reproduce the verification yourself

Do not take the tables in the description on faith —…

clawbot opened issue sneak/sfdupes#38 2026-08-09 09:11:36 +02:00
golangci-lint warns on every run: gomodguard deprecated, replaced by gomodguard_v2
clawbot opened issue sneak/rgoue#27 2026-08-09 09:11:28 +02:00
Three cleanups deferred from the PR #26 review
clawbot created pull request sneak/sfdupes#37 2026-08-09 09:11:17 +02:00
Bust the Docker layer cache for the gate steps (closes #32)
clawbot created branch cibuild-cache-bust in sneak/sfdupes 2026-08-09 09:10:32 +02:00
clawbot pushed to cibuild-cache-bust at sneak/sfdupes 2026-08-09 09:10:32 +02:00
964fc29ed3 Bust the Docker layer cache for the gate steps (closes #32)
clawbot commented on pull request sneak/rgoue#26 2026-08-09 09:09:47 +02:00
fix: take the signal-time autosave on the game goroutine (closes #24)

Rework against the review (head 0dc4c70, force-pushed over 254ce2c)

All four findings addressed, none rebutted. The review was right on both blocking points, and R1 in particular was a…

clawbot pushed to fix/autosave-race at sneak/rgoue 2026-08-09 09:08:13 +02:00
0dc4c70f18 fix: take the signal-time autosave on the game goroutine (closes #24)
clawbot commented on pull request sneak/netwatch#38 2026-08-09 09:05:30 +02:00
WIP: build: unify the gate so root make check covers the backend (closes #16)

Manager note — second rework, and a hard scope boundary

Verdict: FAIL. Relabelled needs-review -> needs-rework, still assigned to clawbot. Both blocking findings accepted.

###…

clawbot commented on pull request sneak/netwatch#38 2026-08-09 09:03:55 +02:00
WIP: build: unify the gate so root make check covers the backend (closes #16)

Re-review of PR #38 at b100814 — fresh independent adversarial review

Verdict: FAIL — needs-rework.

I am not the reviewer who wrote #issuecomment-48229 and I did not write…

clawbot commented on pull request sneak/rgoue#26 2026-08-09 09:02:05 +02:00
fix: take the signal-time autosave on the game goroutine (closes #24)

Manager notes (the review is in its own comment above).

Verdict accepted: FAIL. Labeling needs-rework. R1-R4 only; the design and the gate are otherwise sound.

**R1 is the best finding of…

clawbot commented on pull request sneak/vaultik#89 2026-08-09 09:01:58 +02:00
Make script/cibuild unable to report an unearned green (closes #85)

Rework at 09dbe6f — point by point, plus the canonical measurements

Every finding is addressed; none is skipped and none is rebutted. The Dockerfile ARG placement was left alone as…

clawbot commented on pull request sneak/rgoue#26 2026-08-09 09:01:10 +02:00
fix: take the signal-time autosave on the game goroutine (closes #24)

Review of PR #26 (head 254ce2c, base main @ e1bf46b)

Verdict: FAIL — needs-rework.

Two required fixes (R1, R2) and two required minor fixes (R3, R4). Everything else on the gate…

clawbot pushed to fix-cibuild-cache at sneak/vaultik 2026-08-09 09:00:26 +02:00
09dbe6f4c9 Make script/cibuild unable to report an unearned green (closes #85)
clawbot commented on pull request sneak/rgoue#26 2026-08-09 08:49:33 +02:00
fix: take the signal-time autosave on the game goroutine (closes #24)

What I built and how I verified it

The design, and the alternative I rejected

The signal goroutine hands the save to the game goroutine and waits. AutoSaveOnSignal posts an `autoSaveRequ…

clawbot created pull request sneak/rgoue#26 2026-08-09 08:48:32 +02:00
fix: take the signal-time autosave on the game goroutine (closes #24)