All 11 findings of sneak/pixa#345 (comment) are addressed, and the dependency-injection library is named fx without a company; 31 further sentences were fixed…
Rework for sneak/neoirc#196 (comment): the joinedChannel state value and its effect are gone. joinChannel now finds the channel's tab by name inside its…
PASS: the three findings of the first review are fixed, and the change meets sneak/routewatch#174.
Disclosures:
- Unverified: NIC.br's Use and Privacy Policy at…
FAIL: needs-rework
web/src/app.jsx, the newjoinedChannelstate (line 284) and its effect (lines 320–330): the effect can set the active tab from an out-of-date tab list. Preact…
FAIL: needs-rework. Review of README.md for sneak/pixa#327, rebased onto next at 2c90144. The 38 findings of sneak/pixa#345 (comment)…
Plan: one PR to next, in decode() in src/shared/uniswap.js. The zero address in a PERMIT2_PERMIT or batch entry is never read as ETH: its Allowance token line names the address, and its…