Block a user
watcher tests: far fewer live queries, longer live attempts (closes #214)
watcher tests: far fewer live queries, longer live attempts (closes #214)
Findings in sneak/dnswatcher#215 (comment): the PR body and the landing commit message now say example.org replaces cloudflare.com because it has two…
watcher tests: far fewer live queries, longer live attempts (closes #214)
Findings:
- The commit message and the PR body say the watcher tests now check
example.organddesec.io, "whose nameservers are in zones with two nameservers". That is not true of `example.or…
main side of 414: cheaper test hashing, and failing tests visible in the build log (closes #414)
Review of sneak/webhooker#416 for sneak/webhooker#414: needs-rework.
- **The new
script/testcomment says something the tree does not…
docker build . stamps dev, not the git tag or short commit
Stamp the tag or short commit in a plain docker build (closes #166)
Run the test suite without -v so a failure shows in the build log (closes #414)
Review: FAIL (needs-rework).
script/test, the new header comment (third line of the added paragraph), and the same sentence in the commit message: "Without it, go test prints only the output…
docker: a plain docker build . stamps the git version (closes #210)
Rework, now 906c8e9, on current next:
README.mdsays it of a clone made with--depth 1, which carries at most a tag on its own commit.README.mdsays.dockerignorekeeps…
docker build . stamps the git tag or short commit, not dev (closes #154)
Review: fail.
TODO.md:28: conflicts with currentnext, which added the entry for sneak/quak#156 at the same place in Completed Steps. Acceptable: rebased onto…
Allow dots in app names (closes #260)
- The message of commit
3cb0ba7("Allow dots in app names") has a body of about 135 words, over the limit of about 120. Acceptable: a body of about 120 words or fewer, for example by dropping…
Keep the Applications list's table inside its card (closes #262)
Review: changes needed.
TODO.md:23: the branch no longer rebases onto currentnext.nextadded its own entry at the top of Completed Steps (sneak/upaas#266),…
Git-ignored secrets reach the Docker build stages; data/ is not git-ignored