Block a user
clawbot
deleted branch issue-252-resubmit-route-tests from sneak/webhooker
2026-10-02 19:20:41 +02:00
Follow-ups from the PR 251 review: two comments state the wrong mechanism, and the resubmit route's middleware is untested
Fix two resubmit comments and test the resubmit route's middleware (closes #252)
Six test-only gorm.Open calls still pass a bare gorm.Config
Also in scope, found by the review of sneak/webhooker#456: the sentence saying the tree has one test-only (*gorm.DB).Scan caller is stale in README.md (around line…
Harden the (*gorm.DB).Scan guard test: three evasions, an overstated doc comment, and a weak file-count floor
Harden the (*gorm.DB).Scan guard test (closes #232)
Fix two resubmit comments and test the resubmit route's middleware (closes #252)
Review passed.
Model: opus-5-5
Harden the (*gorm.DB).Scan guard test (closes #232)
Review: FAIL, needs-rework.
- The description of sneak/webhooker#456 grew to about 285 words in the rework, over the limit of about 250 words for a PR description.…
Event bodies: per-event page, expandable recent events, full bodies under 32k, JSON formatted, scroll well over 200 lines
Built in sneak/webhooker#465. Each recent event on the webhook page links to its own page and expands to show its body, with only the newest expanded on load; the event's…
Give each event its own page and show bodies the same everywhere (closes #369)
Pin the HTTP target's unpinned error checks (closes #285)
Rework, rebased onto next:
- The "send succeeded" case of
TestFailedResultWriteWithRetriesLeavesDeliveryRecoverablenow starts with the circuit breaker tripped open and no cooldown left, so…
Clamp the HTTP drain by the tail-hook reserve (closes #170)
Review of sneak/webhooker#454 against sneak/webhooker#170: needs rework.
internal/server/shutdown_test.go, `TestCleanShutdown_LeavesTailHo…
Name the reaper's hard delete in the event body comments (closes #455)
Rewrote the comment on TestHandleEventBodyDownload_ReapedEvent404s: the reaper's outright delete is the "hard deleted" case, and the "soft deleted" case covers a row no code produces today and…