The eventBodyQuery comment credits the soft-delete predicate for refusing a reaped event #455

New Issue

2026-10-02T18:12:33+02:00

clawbot commented

2026-10-02 18:12:33 +02:00

The comment on eventBodyQuery in internal/handlers/event_body.go says its deleted_at IS NULL predicate "is what stops a reaped event still being downloadable". The retention reaper deletes event rows outright (deleteEvents in internal/database/retention.go runs Unscoped()), and nothing else deletes an event row, so a reaped event is simply gone and the predicate plays no part in refusing it. A reader who trusts the comment will assume reaped events are still on disk.

Done when the comment names the actual mechanism. Comment only; behaviour is correct.

Model: opus-5-5

The comment on `eventBodyQuery` in `internal/handlers/event_body.go` says its `deleted_at IS NULL` predicate "is what stops a reaped event still being downloadable". The retention reaper deletes event rows outright (`deleteEvents` in `internal/database/retention.go` runs `Unscoped()`), and nothing else deletes an event row, so a reaped event is simply gone and the predicate plays no part in refusing it. A reader who trusts the comment will assume reaped events are still on disk. Done when the comment names the actual mechanism. Comment only; behaviour is correct. Model: opus-5-5

clawbot referenced this issue

2026-10-02 18:23:40 +02:00

Fix two resubmit comments and test the resubmit route's middleware (closes #252) #457

clawbot referenced this issue

2026-10-02 18:23:50 +02:00

Follow-ups from the PR 251 review: two comments state the wrong mechanism, and the resubmit route's middleware is untested #252

clawbot referenced this issue from a commit

2026-10-02 18:30:47 +02:00

Name the reaper's hard delete in the eventBodyQuery comment (closes #455)

clawbot referenced this issue from a commit

2026-10-02 18:53:56 +02:00

Name the reaper's hard delete in the eventBodyQuery comment (closes #455)

clawbot referenced a pull request that will close this issue

2026-10-02 18:54:02 +02:00

Name the reaper's hard delete in the event body comments (closes #455) #461

clawbot commented

2026-10-02 18:54:07 +02:00

#461 rewrites the comment on eventBodyQuery: a reaped event is gone because the retention reaper deletes event rows outright. It also says the deleted_at IS NULL predicate excludes nothing today, since no code path soft-deletes an event. Only the comment changed.

Judgement call: the comment on TestHandleEventBodyDownload_ReapedEvent404s makes a similar claim and is left as it is, outside this issue's scope.

Model: opus-5-5

https://git.eeqj.de/sneak/webhooker/pulls/461 rewrites the comment on `eventBodyQuery`: a reaped event is gone because the retention reaper deletes event rows outright. It also says the `deleted_at IS NULL` predicate excludes nothing today, since no code path soft-deletes an event. Only the comment changed. Judgement call: the comment on `TestHandleEventBodyDownload_ReapedEvent404s` makes a similar claim and is left as it is, outside this issue's scope. Model: opus-5-5

clawbot referenced this issue

2026-10-02 19:02:36 +02:00

Name the reaper's hard delete in the event body comments (closes #455) #461

clawbot referenced this issue from a commit

2026-10-02 19:11:24 +02:00

Name the reaper's hard delete in the event body comments (closes #455)

clawbot closed this issue

2026-10-02 19:36:30 +02:00

clawbot referenced this issue from a commit

2026-10-02 19:36:32 +02:00

Name the reaper's hard delete in the event body comments (closes #455)

Sign in to join this conversation.