clawbot
bef9986542
All checks were successful
check / check (push) Successful in 3m3s
fx defaults to a 15s stop timeout and the Dockerfile sets no grace override, so Docker SIGKILLed at 10s and the bounded shutdown #130 built — including the log line that tells an operator a component is wedged — was unreachable in the image this repo produces. Sets fx.StopTimeout to 5s, and lowers the HTTP drain to 3s so a full-length drain no longer exhausts the whole sequence budget and skip every later hook, database close included. The Sentry flush, which runs in the same hook and honours no context, is clamped to the remaining stop budget less a 2s tail reserve, so a stalled flush drops Sentry events rather than the database close. Also fixes a latent coin flip in the shared stop-hook waiter, which reported "shutdown timed out" about half the time for a component that drained cleanly against an already-expired context. Independently reviewed three times. The final reviewer derived a stronger invariant than the implementation claims — the server hook's absolute end is bounded at stopTimeout minus the reserve regardless of drain length or of time consumed by preceding hooks — and confirmed the guard's 10ms sweep cannot step over the maximum, since both breakpoints land on its grid. Both Sentry probe arms, the docker stop demo and every mutation were reproduced independently. Known residual, filed separately: the HTTP drain itself is not clamped by the reserve, so slow preceding hooks can still jointly exhaust the budget. Demonstrated with a 2.2s sweeper delay.
60 lines
1.3 KiB
Go
60 lines
1.3 KiB
Go
package server_test
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
"sneak.berlin/go/webhooker/internal/server"
|
|
)
|
|
|
|
// TestSentryFlushBudget covers the clamp that keeps the Sentry flush
|
|
// from spending the tail hooks' share of the fx stop budget.
|
|
// sentry.Flush ignores the stop context, so without the clamp a
|
|
// stalled flush adds its whole timeout on top of the HTTP drain.
|
|
func TestSentryFlushBudget(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tests := []struct {
|
|
name string
|
|
remaining time.Duration
|
|
want time.Duration
|
|
}{
|
|
{
|
|
name: "full drain leaves only the reserve",
|
|
remaining: server.TailHookReserve,
|
|
want: 0,
|
|
},
|
|
{
|
|
name: "expired budget",
|
|
remaining: -time.Second,
|
|
want: 0,
|
|
},
|
|
{
|
|
name: "sliver above the reserve is not worth it",
|
|
remaining: server.TailHookReserve + 10*time.Millisecond,
|
|
want: 0,
|
|
},
|
|
{
|
|
name: "partial flush when some room is left",
|
|
remaining: server.TailHookReserve + time.Second,
|
|
want: time.Second,
|
|
},
|
|
{
|
|
name: "capped at the nominal timeout",
|
|
remaining: time.Hour,
|
|
want: 2 * time.Second,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
require.Equal(
|
|
t, tt.want, server.SentryFlushBudget(tt.remaining),
|
|
)
|
|
})
|
|
}
|
|
}
|