32bd40b313
All checks were successful
check / check (push) Successful in 58s
The webhook handler now builds DeliveryTask structs carrying all target config and event data inline (for bodies ≤16KB) and sends them through the delivery channel. In the happy path, the engine delivers without reading from any database — it only writes to record delivery results. For large bodies (≥16KB), Body is nil and the engine fetches it from the per-webhook database on demand. Retry timers also carry the full DeliveryTask, so retries avoid unnecessary DB reads. The database is used for crash recovery only: on startup the engine scans for interrupted pending/retrying deliveries and re-queues them. Implements owner feedback from issue #15: > the message in the <=16KB case should have everything it needs to do > its delivery. it shouldn't touch the db until it has a success or > failure to record.
135 lines
2.9 KiB
Go
135 lines
2.9 KiB
Go
package handlers
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"go.uber.org/fx"
|
|
"go.uber.org/fx/fxtest"
|
|
"sneak.berlin/go/webhooker/internal/config"
|
|
"sneak.berlin/go/webhooker/internal/database"
|
|
"sneak.berlin/go/webhooker/internal/delivery"
|
|
"sneak.berlin/go/webhooker/internal/globals"
|
|
"sneak.berlin/go/webhooker/internal/healthcheck"
|
|
"sneak.berlin/go/webhooker/internal/logger"
|
|
"sneak.berlin/go/webhooker/internal/session"
|
|
)
|
|
|
|
// noopNotifier is a no-op delivery.Notifier for tests.
|
|
type noopNotifier struct{}
|
|
|
|
func (n *noopNotifier) Notify([]delivery.DeliveryTask) {}
|
|
|
|
func TestHandleIndex(t *testing.T) {
|
|
var h *Handlers
|
|
|
|
app := fxtest.New(
|
|
t,
|
|
fx.Provide(
|
|
globals.New,
|
|
logger.New,
|
|
func() *config.Config {
|
|
return &config.Config{
|
|
DBURL: "file:" + t.TempDir() + "/test.db?cache=shared&mode=rwc",
|
|
DataDir: t.TempDir(),
|
|
}
|
|
},
|
|
database.New,
|
|
database.NewWebhookDBManager,
|
|
healthcheck.New,
|
|
session.New,
|
|
func() delivery.Notifier { return &noopNotifier{} },
|
|
New,
|
|
),
|
|
fx.Populate(&h),
|
|
)
|
|
app.RequireStart()
|
|
defer app.RequireStop()
|
|
|
|
// Since we can't test actual template rendering without templates,
|
|
// let's test that the handler is created and doesn't panic
|
|
handler := h.HandleIndex()
|
|
assert.NotNil(t, handler)
|
|
}
|
|
|
|
func TestRenderTemplate(t *testing.T) {
|
|
var h *Handlers
|
|
|
|
app := fxtest.New(
|
|
t,
|
|
fx.Provide(
|
|
globals.New,
|
|
logger.New,
|
|
func() *config.Config {
|
|
return &config.Config{
|
|
DBURL: "file:" + t.TempDir() + "/test.db?cache=shared&mode=rwc",
|
|
DataDir: t.TempDir(),
|
|
}
|
|
},
|
|
database.New,
|
|
database.NewWebhookDBManager,
|
|
healthcheck.New,
|
|
session.New,
|
|
func() delivery.Notifier { return &noopNotifier{} },
|
|
New,
|
|
),
|
|
fx.Populate(&h),
|
|
)
|
|
app.RequireStart()
|
|
defer app.RequireStop()
|
|
|
|
t.Run("handles missing templates gracefully", func(t *testing.T) {
|
|
req := httptest.NewRequest(http.MethodGet, "/", nil)
|
|
w := httptest.NewRecorder()
|
|
|
|
data := map[string]interface{}{
|
|
"Version": "1.0.0",
|
|
}
|
|
|
|
// When a non-existent template name is requested, renderTemplate
|
|
// should return an internal server error
|
|
h.renderTemplate(w, req, "nonexistent.html", data)
|
|
|
|
// Should return internal server error when template is not found
|
|
assert.Equal(t, http.StatusInternalServerError, w.Code)
|
|
})
|
|
}
|
|
|
|
func TestFormatUptime(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
duration string
|
|
expected string
|
|
}{
|
|
{
|
|
name: "minutes only",
|
|
duration: "45m",
|
|
expected: "45m",
|
|
},
|
|
{
|
|
name: "hours and minutes",
|
|
duration: "2h30m",
|
|
expected: "2h 30m",
|
|
},
|
|
{
|
|
name: "days, hours and minutes",
|
|
duration: "25h45m",
|
|
expected: "1d 1h 45m",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
d, err := time.ParseDuration(tt.duration)
|
|
require.NoError(t, err)
|
|
|
|
result := formatUptime(d)
|
|
assert.Equal(t, tt.expected, result)
|
|
})
|
|
}
|
|
}
|