4dd4dfa5eb
All checks were successful
check / check (push) Successful in 56s
DBURL → DATA_DIR consolidation:
- Remove DBURL env var entirely; main DB now lives at {DATA_DIR}/webhooker.db
- database.go constructs DB path from config.DataDir, ensures dir exists
- Update DATA_DIR prod default from /data/events to /data
- Update all tests to use DataDir instead of DBURL
- Update Dockerfile: /data (not /data/events) for all SQLite databases
- Update README configuration table, Docker examples, architecture docs
Dead code removal:
- Remove unused IndexResponse struct (handlers/index.go)
- Remove unused TemplateData struct (handlers/handlers.go)
Stale comment cleanup:
- Remove TODO in server.go (DB cleanup handled by fx lifecycle)
- Fix nolint:golint → nolint:revive on ServerParams for consistency
- Clean up verbose middleware/routing comments in routes.go
- Fix TODO fan-out description (worker pool, not goroutine-per-target)
.gitignore fixes:
- Add data/ directory to gitignore
- Remove stale config.yaml entry (env-only config since rework)
76 lines
1.6 KiB
Go
76 lines
1.6 KiB
Go
package database
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"go.uber.org/fx/fxtest"
|
|
"sneak.berlin/go/webhooker/internal/config"
|
|
"sneak.berlin/go/webhooker/internal/globals"
|
|
"sneak.berlin/go/webhooker/internal/logger"
|
|
)
|
|
|
|
func TestDatabaseConnection(t *testing.T) {
|
|
// Set up test dependencies
|
|
lc := fxtest.NewLifecycle(t)
|
|
|
|
// Create globals
|
|
globals.Appname = "webhooker-test"
|
|
globals.Version = "test"
|
|
globals.Buildarch = "test"
|
|
|
|
g, err := globals.New(lc)
|
|
if err != nil {
|
|
t.Fatalf("Failed to create globals: %v", err)
|
|
}
|
|
|
|
// Create logger
|
|
l, err := logger.New(lc, logger.LoggerParams{Globals: g})
|
|
if err != nil {
|
|
t.Fatalf("Failed to create logger: %v", err)
|
|
}
|
|
|
|
// Create config with DataDir pointing to a temp directory
|
|
c := &config.Config{
|
|
DataDir: t.TempDir(),
|
|
Environment: "dev",
|
|
}
|
|
|
|
// Create database
|
|
db, err := New(lc, DatabaseParams{
|
|
Config: c,
|
|
Logger: l,
|
|
})
|
|
if err != nil {
|
|
t.Fatalf("Failed to create database: %v", err)
|
|
}
|
|
|
|
// Start lifecycle (this will trigger the connection)
|
|
ctx := context.Background()
|
|
err = lc.Start(ctx)
|
|
if err != nil {
|
|
t.Fatalf("Failed to connect to database: %v", err)
|
|
}
|
|
defer func() {
|
|
if stopErr := lc.Stop(ctx); stopErr != nil {
|
|
t.Errorf("Failed to stop lifecycle: %v", stopErr)
|
|
}
|
|
}()
|
|
|
|
// Verify we can get the DB instance
|
|
if db.DB() == nil {
|
|
t.Error("Expected non-nil database connection")
|
|
}
|
|
|
|
// Test that we can perform a simple query
|
|
var result int
|
|
err = db.DB().Raw("SELECT 1").Scan(&result).Error
|
|
if err != nil {
|
|
t.Fatalf("Failed to execute test query: %v", err)
|
|
}
|
|
|
|
if result != 1 {
|
|
t.Errorf("Expected query result to be 1, got %d", result)
|
|
}
|
|
}
|