check / check (push) Successful in 3m17s
On Linux a connection to the unspecified address [::] or 0.0.0.0 reaches the host's own loopback, and the SSRF guard let [::] through. Both unspecified addresses now sit in alwaysBlockedNetworks, so an allowlist reaches loopback only through an entry that covers a loopback address, never through one that covers only 0.0.0.0 or ::; ::/128 joins the default blocklist beside 0.0.0.0/8. IPv6 multicast (ff00::/8) and documentation space (2001:db8::/32) are refused by default. Every default blocklist entry gets a one-line comment, and the README, the rules above each list, the two pinning tests and the allowlist refusal test follow. Model: opus-5-5
211 lines
4.4 KiB
Go
211 lines
4.4 KiB
Go
package delivery_test
|
|
|
|
import (
|
|
"context"
|
|
"net"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"sneak.berlin/go/webhooker/internal/delivery"
|
|
)
|
|
|
|
func TestGuardCheckIP_PrivateRanges(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tests := []struct {
|
|
name string
|
|
ip string
|
|
blocked bool
|
|
}{
|
|
{"loopback 127.0.0.1", "127.0.0.1", true},
|
|
{"loopback 127.0.0.2", "127.0.0.2", true},
|
|
{"loopback 127.255.255.255", "127.255.255.255", true},
|
|
{"10.0.0.0", "10.0.0.0", true},
|
|
{"10.0.0.1", "10.0.0.1", true},
|
|
{"10.255.255.255", "10.255.255.255", true},
|
|
{"172.16.0.1", "172.16.0.1", true},
|
|
{"172.31.255.255", "172.31.255.255", true},
|
|
{"172.15.255.255", "172.15.255.255", false},
|
|
{"172.32.0.0", "172.32.0.0", false},
|
|
{"192.168.0.1", "192.168.0.1", true},
|
|
{"192.168.255.255", "192.168.255.255", true},
|
|
{"169.254.0.1", "169.254.0.1", true},
|
|
{metadataIP, metadataIP, true},
|
|
{"8.8.8.8", "8.8.8.8", false},
|
|
{"1.1.1.1", "1.1.1.1", false},
|
|
{publicIP, publicIP, false},
|
|
{"::1", "::1", true},
|
|
{"fd00::1", "fd00::1", true},
|
|
{"fc00::1", "fc00::1", true},
|
|
{"fe80::1", "fe80::1", true},
|
|
{
|
|
"2607:f8b0:4004:800::200e",
|
|
"2607:f8b0:4004:800::200e",
|
|
false,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
ip := net.ParseIP(tt.ip)
|
|
|
|
require.NotNil(t, ip,
|
|
"failed to parse IP %s", tt.ip,
|
|
)
|
|
|
|
refused := delivery.NewTestGuard().ExportCheckIP(ip) != nil
|
|
|
|
assert.Equal(t,
|
|
tt.blocked,
|
|
refused,
|
|
"default guard refuses %s = %v, want %v",
|
|
tt.ip,
|
|
refused,
|
|
tt.blocked,
|
|
)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestValidateTargetURL_Blocked(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
blockedURLs := []string{
|
|
loopbackHookURL,
|
|
"http://127.0.0.1:8080/hook",
|
|
"https://10.0.0.1/hook",
|
|
"http://192.168.1.1/webhook",
|
|
"http://172.16.0.1/api",
|
|
metadataURL,
|
|
"http://[::1]/hook",
|
|
"http://[fc00::1]/hook",
|
|
"http://[fe80::1]/hook",
|
|
"http://0.0.0.0/hook",
|
|
}
|
|
|
|
for _, u := range blockedURLs {
|
|
t.Run(u, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
err := delivery.NewTestGuard().ValidateTargetURL(
|
|
context.Background(), u,
|
|
)
|
|
|
|
assert.Error(t, err,
|
|
"URL %s should be blocked", u,
|
|
)
|
|
})
|
|
}
|
|
}
|
|
|
|
// TestDefaultGuard_RefusesUnspecifiedMulticastAndDocumentation
|
|
// covers the unspecified addresses and the IPv6 multicast and
|
|
// documentation ranges: with no allowlist set, each is refused
|
|
// both when a target is created and when a delivery dials it.
|
|
func TestDefaultGuard_RefusesUnspecifiedMulticastAndDocumentation(
|
|
t *testing.T,
|
|
) {
|
|
t.Parallel()
|
|
|
|
guard := delivery.NewTestGuard()
|
|
|
|
targets := []string{
|
|
// The unspecified addresses. On Linux a connection to
|
|
// either reaches this host's loopback.
|
|
"http://0.0.0.0:8080/hook",
|
|
"http://[::]:8080/hook",
|
|
// IPv6 multicast, all nodes.
|
|
"http://[ff02::1]/hook",
|
|
// IPv6 documentation.
|
|
"http://[2001:db8::1]/hook",
|
|
}
|
|
|
|
for _, target := range targets {
|
|
t.Run(target, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
require.Error(t,
|
|
guard.ValidateTargetURL(context.Background(), target),
|
|
"%s must be refused at target creation", target,
|
|
)
|
|
|
|
assertDialRefused(t, guard, target)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestValidateTargetURL_Allowed(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
allowedURLs := []string{
|
|
"https://example.com/hook",
|
|
"http://93.184.216.34/webhook",
|
|
"https://hooks.slack.com/services/T00/B00/xxx",
|
|
}
|
|
|
|
for _, u := range allowedURLs {
|
|
t.Run(u, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
err := delivery.NewTestGuard().ValidateTargetURL(
|
|
context.Background(), u,
|
|
)
|
|
|
|
assert.NoError(t, err,
|
|
"URL %s should be allowed", u,
|
|
)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestValidateTargetURL_InvalidScheme(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
err := delivery.NewTestGuard().ValidateTargetURL(
|
|
context.Background(), "ftp://example.com/hook",
|
|
)
|
|
|
|
require.Error(t, err)
|
|
|
|
assert.Contains(t, err.Error(),
|
|
"unsupported URL scheme",
|
|
)
|
|
}
|
|
|
|
func TestValidateTargetURL_EmptyHost(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
err := delivery.NewTestGuard().ValidateTargetURL(
|
|
context.Background(), "http:///path",
|
|
)
|
|
|
|
assert.Error(t, err)
|
|
}
|
|
|
|
func TestValidateTargetURL_InvalidURL(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
err := delivery.NewTestGuard().ValidateTargetURL(
|
|
context.Background(), "://invalid",
|
|
)
|
|
|
|
assert.Error(t, err)
|
|
}
|
|
|
|
func TestBlockedNetworks_Initialized(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
nets := delivery.ExportBlockedNetworks()
|
|
|
|
assert.NotEmpty(t, nets,
|
|
"blockedNetworks should be initialized",
|
|
)
|
|
|
|
assert.GreaterOrEqual(t, len(nets), 8,
|
|
"should have at least 8 blocked network ranges",
|
|
)
|
|
}
|