clawbot
128eb1b644
check / check (push) Successful in 7m57s
The test helpers lived in ordinary `testing.go` files inside the config, database, middleware and session packages, so they were built into the binary and the shared `test-support` lint rule could not see them. The four files are gone: the session's helpers move into its own `_test.go` file, and the rest into `configtest`, `databasetest` and `middlewaretest`, which the `depguard` deny list now names, so a non-test file importing them fails lint. The test-support packages build through the production constructors. Judgement call: the session, the middleware and the webhook database manager now take the plain logger they log through, which the application wiring provides. Judgement call: two idle-expiry tests move the stored timestamps back instead of advancing a fake clock. Model: opus-5-5
53 lines
1.3 KiB
Go
53 lines
1.3 KiB
Go
// Package configtest holds test support for code that reads the
|
|
// process environment.
|
|
package configtest
|
|
|
|
import (
|
|
"os"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// ClearEnv unsets every variable in the process environment
|
|
// for the rest of the test, so a test sees only the variables it sets
|
|
// itself, not whatever the developer's shell exports. When the test
|
|
// ends it leaves the environment exactly as it found it: each variable
|
|
// it unset is put back, and any variable added since is removed.
|
|
func ClearEnv(t *testing.T) {
|
|
t.Helper()
|
|
|
|
present := make(map[string]bool)
|
|
|
|
for _, entry := range os.Environ() {
|
|
key, _, _ := strings.Cut(entry, "=")
|
|
present[key] = true
|
|
|
|
// t.Setenv registers the restore; the Unsetenv after it is
|
|
// what makes the key absent, since a key set to the empty
|
|
// string is still present, and godotenv will not overwrite a
|
|
// present key.
|
|
t.Setenv(key, "")
|
|
|
|
err := os.Unsetenv(key)
|
|
if err != nil {
|
|
t.Fatalf("unsetting %s: %v", key, err)
|
|
}
|
|
}
|
|
|
|
// A variable the test adds other than through t.Setenv, as loading
|
|
// a .env file does, has no restore of its own.
|
|
t.Cleanup(func() {
|
|
for _, entry := range os.Environ() {
|
|
key, _, _ := strings.Cut(entry, "=")
|
|
if present[key] {
|
|
continue
|
|
}
|
|
|
|
err := os.Unsetenv(key)
|
|
if err != nil {
|
|
t.Errorf("unsetting %s: %v", key, err)
|
|
}
|
|
}
|
|
})
|
|
}
|