TestProcessRetryTask_LargeBody_FetchFromDB and TestProcessRetryTask_SuccessfulRetry checked only that the delivery ended delivered. A retry that sent an empty or wrong body still passed them. Both now record the body the target received and compare it with the stored event body byte for byte. This is the same check TestProcessNewTask_LargeBody_FetchFromDB already makes on the new-delivery path.
I deleted the event-body fetch in processRetryTask by hand. Both tests then failed on the body comparison. I restored the fetch, and engine.go is unchanged in this PR.
Retry-path tests I left alone: TestProcessRetryTask_TargetPresent_StillDelivers and TestProcessRetryTask_TargetUnreadable_StillDelivers test the deleted-target check and count requests to the target, and TestWorkerLifecycle_ProcessesRetryChannel tests that the retry queue is consumed. None of them is about the body, so asserting it there would only duplicate this check.
`TestProcessRetryTask_LargeBody_FetchFromDB` and `TestProcessRetryTask_SuccessfulRetry` checked only that the delivery ended `delivered`. A retry that sent an empty or wrong body still passed them. Both now record the body the target received and compare it with the stored event body byte for byte. This is the same check `TestProcessNewTask_LargeBody_FetchFromDB` already makes on the new-delivery path.
I deleted the event-body fetch in `processRetryTask` by hand. Both tests then failed on the body comparison. I restored the fetch, and `engine.go` is unchanged in this PR.
Retry-path tests I left alone: `TestProcessRetryTask_TargetPresent_StillDelivers` and `TestProcessRetryTask_TargetUnreadable_StillDelivers` test the deleted-target check and count requests to the target, and `TestWorkerLifecycle_ProcessesRetryChannel` tests that the retry queue is consumed. None of them is about the body, so asserting it there would only duplicate this check.
Test change only. Closes https://git.eeqj.de/sneak/webhooker/issues/294.
Model: opus-5-5
clawbot
self-assigned this 2026-10-02 17:33:18 +02:00
TestProcessRetryTask_LargeBody_FetchFromDB and
TestProcessRetryTask_SuccessfulRetry checked only that the delivery
ended delivered, so a retry that sent an empty or wrong body still
passed. Both now compare the body received at the sink with the stored
event body, as the processNewTask large-body test already does.
Model: opus-5-5
Review passed: both retry-path tests now compare the body the target received with the stored event body byte for byte, and both fail when the event-body fetch in processRetryTask is deleted.
Model: opus-5-5
Review passed: both retry-path tests now compare the body the target received with the stored event body byte for byte, and both fail when the event-body fetch in `processRetryTask` is deleted.
Model: opus-5-5
clawbot
merged commit 503c57efd9 into next2026-10-02 18:03:20 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
TestProcessRetryTask_LargeBody_FetchFromDBandTestProcessRetryTask_SuccessfulRetrychecked only that the delivery endeddelivered. A retry that sent an empty or wrong body still passed them. Both now record the body the target received and compare it with the stored event body byte for byte. This is the same checkTestProcessNewTask_LargeBody_FetchFromDBalready makes on the new-delivery path.I deleted the event-body fetch in
processRetryTaskby hand. Both tests then failed on the body comparison. I restored the fetch, andengine.gois unchanged in this PR.Retry-path tests I left alone:
TestProcessRetryTask_TargetPresent_StillDeliversandTestProcessRetryTask_TargetUnreadable_StillDeliverstest the deleted-target check and count requests to the target, andTestWorkerLifecycle_ProcessesRetryChanneltests that the retry queue is consumed. None of them is about the body, so asserting it there would only duplicate this check.Test change only. Closes #294.
Model: opus-5-5
Review passed: both retry-path tests now compare the body the target received with the stored event body byte for byte, and both fail when the event-body fetch in
processRetryTaskis deleted.Model: opus-5-5