The check workflow's build step was named "Build Docker image (runs make check)", but the image has never run make check. Its lint stage runs make fmt-check and calls golangci-lint directly, and its builder stage runs make test and make build. The step name now lists those four. No other step name or comment in the workflow names something it does not run.
Two README sentences are now scoped accurately:
The Prerequisites bullet says Docker is needed for make lint, and so for make check. It no longer says only "the test stage of the CI gate".
"only script/test and script/fmt-check run on the host" now says it is about the steps make check runs, not the whole repo.
Judgement call: make fmt in this repo formats only Go code, so I wrapped the README lines by hand to the width the file already uses.
The `check` workflow's build step was named "Build Docker image (runs make check)", but the image has never run `make check`. Its lint stage runs `make fmt-check` and calls `golangci-lint` directly, and its builder stage runs `make test` and `make build`. The step name now lists those four. No other step name or comment in the workflow names something it does not run.
Two README sentences are now scoped accurately:
- The Prerequisites bullet says Docker is needed for `make lint`, and so for `make check`. It no longer says only "the test stage of the CI gate".
- "only `script/test` and `script/fmt-check` run on the host" now says it is about the steps `make check` runs, not the whole repo.
Judgement call: `make fmt` in this repo formats only Go code, so I wrapped the README lines by hand to the width the file already uses.
Fixes https://git.eeqj.de/sneak/webhooker/issues/175
Model: opus-5-5
The workflow's build step said it runs make check, which the image
never does: it runs make fmt-check, golangci-lint, make test and make
build. The README now says Docker is needed for make lint and so for
make check, and scopes "only script/test and script/fmt-check run on
the host" to the steps make check runs.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
The
checkworkflow's build step was named "Build Docker image (runs make check)", but the image has never runmake check. Its lint stage runsmake fmt-checkand callsgolangci-lintdirectly, and its builder stage runsmake testandmake build. The step name now lists those four. No other step name or comment in the workflow names something it does not run.Two README sentences are now scoped accurately:
make lint, and so formake check. It no longer says only "the test stage of the CI gate".script/testandscript/fmt-checkrun on the host" now says it is about the stepsmake checkruns, not the whole repo.Judgement call:
make fmtin this repo formats only Go code, so I wrapped the README lines by hand to the width the file already uses.Fixes #175
Model: opus-5-5
Review passed.
Model: opus-5-5