Remove the no-op MAINTENANCE_MODE setting (closes #317) #430

Merged
clawbot merged 1 commits from issue-317-remove-maintenance-mode into next 2026-10-02 13:27:43 +02:00
Collaborator

MAINTENANCE_MODE only made the healthcheck report maintenanceMode: true. It never changed how a request was served. This removes it from the configuration, the startup configuration log line, the healthcheck JSON, the README, and the Settings page added in #409. It also removes the uncalled Server.MaintenanceMode method and the healthcheck's dependency on the configuration, which the healthcheck took only to read this setting. Tests that set or checked the setting are removed or adjusted.

The configuration reads only the variables it knows, so a MAINTENANCE_MODE left in an environment is now ignored. Nothing detects or warns about it. A value that does not parse used to stop startup; it no longer does.

The healthcheck JSON no longer has a maintenanceMode key.

Judgement call: cleanupForExit stays. Its one caller is the normal shutdown path, and all it does is log "cleaning up", which has nothing to do with this setting. Removing it would change shutdown logging, which is outside this issue.

Model: opus-5-5

`MAINTENANCE_MODE` only made the healthcheck report `maintenanceMode: true`. It never changed how a request was served. This removes it from the configuration, the startup configuration log line, the healthcheck JSON, the README, and the Settings page added in https://git.eeqj.de/sneak/webhooker/pulls/409. It also removes the uncalled `Server.MaintenanceMode` method and the healthcheck's dependency on the configuration, which the healthcheck took only to read this setting. Tests that set or checked the setting are removed or adjusted. The configuration reads only the variables it knows, so a `MAINTENANCE_MODE` left in an environment is now ignored. Nothing detects or warns about it. A value that does not parse used to stop startup; it no longer does. The healthcheck JSON no longer has a `maintenanceMode` key. Judgement call: `cleanupForExit` stays. Its one caller is the normal shutdown path, and all it does is log "cleaning up", which has nothing to do with this setting. Removing it would change shutdown logging, which is outside this issue. Model: opus-5-5
clawbot self-assigned this 2026-10-02 12:57:29 +02:00
clawbot added 1 commit 2026-10-02 12:57:30 +02:00
MAINTENANCE_MODE only made the healthcheck report
maintenanceMode: true; no request was ever served differently. It is
removed from the configuration, the healthcheck JSON, the README and
the Settings page, together with the unused Server.MaintenanceMode
method and the healthcheck's Config dependency, which existed only to
read it. A leftover MAINTENANCE_MODE in the environment is not read,
so it is ignored rather than refused.

Model: opus-5-5
clawbot added the needs-review label 2026-10-02 12:57:32 +02:00
Author
Collaborator

Review passed; keeping cleanupForExit is correct, since it runs on every normal shutdown and was never tied to this setting.

Model: opus-5-5

Review passed; keeping `cleanupForExit` is correct, since it runs on every normal shutdown and was never tied to this setting. Model: opus-5-5
clawbot merged commit 21aafbf928 into next 2026-10-02 13:27:43 +02:00
clawbot deleted branch issue-317-remove-maintenance-mode 2026-10-02 13:27:44 +02:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/webhooker#430