Fail a pending delivery whose target was deleted (closes #293)

Conversation 5 Commits 3 Files Changed 3

+354 -32

3 Commits

Author	SHA1	Message	Date
clawbot	81d758d756	Test a pending delivery whose target is found only on lookup check / check (push) Successful in 4m31s Details When the batch's target map lacks a delivery's target, as it does for every delivery when the batch query fails, sendRecoveredDeliveries looks the target up on its own. The new test hands it an empty map and checks the healthy delivery is queued once, with its real target id and type. Model: opus-5-5	2026-09-29 04:15:01 +00:00
clawbot	608c3b21c8	Re-read a delivery before failing it for a missing target failMissingTarget failed the delivery as the batch had read it, so a delivery a worker sent and let go between the batch read and the ownership check could end failed after a successful attempt. It now reads the row once it owns the delivery and fails it only if the status is still the one the batch read, as processNewTask does. A row that cannot be read is left alone. TestSweepPending_TargetDeleted now checks that the first sweep already queues the healthy delivery and the second does not queue it again. Model: opus-5-5	2026-09-29 04:13:05 +00:00
clawbot	a0bbfca28d	Fail a pending delivery whose target was deleted (closes #293 ) Restart recovery and the pending sweep skipped a pending delivery whose target was missing from the batch's target map, and the sweep did so again every minute for the life of the database. A miss now asks loadTarget: no row fails the delivery with a recorded reason, through the ownership-gated function the retrying paths already use, renamed failMissingTarget with its log line and reason text made to fit both statuses. Any other error leaves the delivery pending, because the map is also empty when its query failed. Model: opus-5-5	2026-09-29 04:13:05 +00:00

Author

SHA1

Message

Date

clawbot

81d758d756

Test a pending delivery whose target is found only on lookup

check / check (push) Successful in 4m31s

Details

When the batch's target map lacks a delivery's target, as it does
for every delivery when the batch query fails, sendRecoveredDeliveries
looks the target up on its own. The new test hands it an empty map
and checks the healthy delivery is queued once, with its real target
id and type.

Model: opus-5-5

2026-09-29 04:15:01 +00:00

clawbot

608c3b21c8

Re-read a delivery before failing it for a missing target

failMissingTarget failed the delivery as the batch had read it, so a
delivery a worker sent and let go between the batch read and the
ownership check could end failed after a successful attempt. It now
reads the row once it owns the delivery and fails it only if the
status is still the one the batch read, as processNewTask does. A row
that cannot be read is left alone.

TestSweepPending_TargetDeleted now checks that the first sweep already
queues the healthy delivery and the second does not queue it again.

Model: opus-5-5

2026-09-29 04:13:05 +00:00

clawbot

a0bbfca28d

Fail a pending delivery whose target was deleted (closes #293 )

Restart recovery and the pending sweep skipped a pending delivery
whose target was missing from the batch's target map, and the sweep
did so again every minute for the life of the database. A miss now
asks loadTarget: no row fails the delivery with a recorded reason,
through the ownership-gated function the retrying paths already use,
renamed failMissingTarget with its log line and reason text made to
fit both statuses. Any other error leaves the delivery pending,
because the map is also empty when its query failed.

Model: opus-5-5

2026-09-29 04:13:05 +00:00

Fail a pending delivery whose target was deleted (closes #293) #329