Say make check needs make bootstrap on a fresh clone #326

Merged
clawbot merged 1 commits from issue-282-check-needs-bootstrap into next 2026-09-29 04:30:15 +02:00
Collaborator

Closes #282 by taking its second option: make check still does not fetch the third-party browser assets, and the README's Entrypoints section now says to run make bootstrap (or make assets) once after cloning.

Why not fetch in the gate: REPO_POLICIES.md and script/check both say make check must not modify any files in the repo, and script/fetch-assets writes into static/ and needs the network.

Docs only; no script or Makefile change. The Quick Start already runs make bootstrap first and is unchanged.

  • Judgement call: the new paragraph sits right after the section's opening statement about Scripts to Rule Them All, not before it, because REPO_POLICIES.md requires the section to open with that statement. "We provide:" moved to its own line so it still leads into the script list.
  • make fmt in this repo formats Go only, so the new lines are wrapped by hand to match the text around them.

Model: opus-5-5

Closes https://git.eeqj.de/sneak/webhooker/issues/282 by taking its second option: `make check` still does not fetch the third-party browser assets, and the README's Entrypoints section now says to run `make bootstrap` (or `make assets`) once after cloning. Why not fetch in the gate: `REPO_POLICIES.md` and `script/check` both say `make check` must not modify any files in the repo, and `script/fetch-assets` writes into `static/` and needs the network. Docs only; no script or Makefile change. The Quick Start already runs `make bootstrap` first and is unchanged. - Judgement call: the new paragraph sits right after the section's opening statement about Scripts to Rule Them All, not before it, because `REPO_POLICIES.md` requires the section to open with that statement. "We provide:" moved to its own line so it still leads into the script list. - `make fmt` in this repo formats Go only, so the new lines are wrapped by hand to match the text around them. Model: opus-5-5
clawbot added the needs-review label 2026-09-29 03:20:40 +02:00
clawbot self-assigned this 2026-09-29 03:20:40 +02:00
clawbot added 1 commit 2026-09-29 03:20:41 +02:00
The third-party browser assets are not committed, so on a fresh clone
make check fails in the tests until make bootstrap (or make assets) has
fetched them. The Entrypoints section now says so up front, and why the
check does not fetch them itself: it must not change files in the repo.

Model: opus-5-5
Author
Collaborator

Review passed.

Model: opus-5-5

Review passed. Model: opus-5-5
clawbot merged commit 3cdab97930 into next 2026-09-29 04:30:15 +02:00
clawbot deleted branch issue-282-check-needs-bootstrap 2026-09-29 04:30:15 +02:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/webhooker#326