sneak/webhooker
1
0
Fork 0
Code Issues 13 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Archive writer lifecycle: evict writers on webhook deletion and sweep idle archives #89

New Issue
Open
opened 2026-08-07 19:11:43 +02:00 by clawbot · 0 comments
clawbot commented 2026-08-07 19:11:43 +02:00
Collaborator
Copy Link

Tracking issue for two non-blocking findings carried through the PR #84 (issue #43) review rounds, so they stop being untracked.

Problems

  1. The per-webhook archiveWriter registry (writers map in internal/delivery) is never evicted when a webhook is deleted: the writer (and any open archive DB handle within its debounce window) lingers for the process lifetime.
  2. Expiry pruning runs only on archive (re)open, and reopens happen only on writes — an archive for a webhook that stops receiving events is never swept, so expired rows persist indefinitely.

Definition of done

  • Deleting a webhook closes and removes its archiveWriter from the registry (and the reaper/deletion path is covered by a test).
  • Idle archives with a configured expiry get pruned without requiring a new write (periodic sweep, or prune scheduled off the debounce timer) — with a test proving rows older than expiry disappear from an idle archive.
  • No behavior change for archives with expiry "never".
Tracking issue for two non-blocking findings carried through the PR #84 (issue #43) review rounds, so they stop being untracked. ## Problems 1. The per-webhook `archiveWriter` registry (`writers` map in `internal/delivery`) is never evicted when a webhook is deleted: the writer (and any open archive DB handle within its debounce window) lingers for the process lifetime. 2. Expiry pruning runs only on archive (re)open, and reopens happen only on writes — an archive for a webhook that stops receiving events is never swept, so expired rows persist indefinitely. ## Definition of done - Deleting a webhook closes and removes its `archiveWriter` from the registry (and the reaper/deletion path is covered by a test). - Idle archives with a configured expiry get pruned without requiring a new write (periodic sweep, or prune scheduled off the debounce timer) — with a test proving rows older than expiry disappear from an idle archive. - No behavior change for archives with expiry "never".
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/webhooker#89
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?