Move schema_migrations table creation into 000.sql with INTEGER version column #56

New Issue

clawbot · 2026-03-25T02:22:02+01:00

clawbot commented

2026-03-25 02:22:02 +01:00

Per sneak/pixa PR #36, the standard migrations pattern should be:

schema_migrations table DDL lives in 000.sql (not inline Go code)
version column is INTEGER PRIMARY KEY (not TEXT)
000.sql is self-contained — contains both CREATE TABLE IF NOT EXISTS and INSERT OR IGNORE INTO schema_migrations (version) VALUES (0)
Go code does zero INSERTs for the bootstrap — just reads and executes 000.sql

This repo currently creates the migrations table inline in Go code. It should be moved to follow the pixa pattern.

Reference implementation: sneak/pixa 000.sql and database.go.

Per [sneak/pixa PR #36](https://git.eeqj.de/sneak/pixa/pulls/36), the standard migrations pattern should be: 1. **`schema_migrations` table DDL lives in `000.sql`** (not inline Go code) 2. **`version` column is `INTEGER PRIMARY KEY`** (not TEXT) 3. **`000.sql` is self-contained** — contains both `CREATE TABLE IF NOT EXISTS` and `INSERT OR IGNORE INTO schema_migrations (version) VALUES (0)` 4. **Go code does zero INSERTs** for the bootstrap — just reads and executes `000.sql` This repo currently creates the migrations table inline in Go code. It should be moved to follow the pixa pattern. Reference implementation: [sneak/pixa `000.sql`](https://git.eeqj.de/sneak/pixa/src/branch/main/internal/database/schema/000.sql) and [`database.go`](https://git.eeqj.de/sneak/pixa/src/branch/main/internal/database/database.go).

clawbot referenced this issue from sneak/pixa

2026-03-25 02:22:24 +01:00

Move schema_migrations table creation into 000.sql #36

clawbot commented

2026-07-26 20:44:34 +02:00

Blocking premise mismatch found while starting this: webhooker does not currently create a schema_migrations table in Go code. There is no schema_migrations table anywhere (not in the code, not in git history) and no .sql migration files. Schema is managed entirely via GORM AutoMigrate — internal/database/models.go Migrate() for the main DB, and per-webhook event DBs in internal/database/webhook_db_manager.go. So there is nothing to "move" into 000.sql.

Adopting the pixa numbered-SQL pattern here would be a from-scratch architecture change (replace AutoMigrate with hand-written SQL DDL for ~9 models across two DB tiers, plus an apply loop and embed) — much larger than #56 as written, and not behavior-preserving. The alternative, a vestigial schema_migrations table alongside AutoMigrate, tracks nothing real.

Your call: (a) close #56 as not-applicable and keep AutoMigrate, or (b) commit to the full SQL-migration conversion as a larger tracked task. Recommend (a) unless you specifically want SQL-file migrations. Assigning to you.

Blocking premise mismatch found while starting this: webhooker does not currently create a `schema_migrations` table in Go code. There is no `schema_migrations` table anywhere (not in the code, not in git history) and no `.sql` migration files. Schema is managed entirely via GORM `AutoMigrate` — `internal/database/models.go` `Migrate()` for the main DB, and per-webhook event DBs in `internal/database/webhook_db_manager.go`. So there is nothing to "move" into `000.sql`. Adopting the pixa numbered-SQL pattern here would be a from-scratch architecture change (replace `AutoMigrate` with hand-written SQL DDL for ~9 models across two DB tiers, plus an apply loop and embed) — much larger than #56 as written, and not behavior-preserving. The alternative, a vestigial `schema_migrations` table alongside `AutoMigrate`, tracks nothing real. Your call: (a) close #56 as not-applicable and keep `AutoMigrate`, or (b) commit to the full SQL-migration conversion as a larger tracked task. Recommend (a) unless you specifically want SQL-file migrations. Assigning to you.

sneak was assigned by clawbot

2026-07-26 20:44:35 +02:00

clawbot referenced this issue

2026-08-07 13:12:23 +02:00

1.0/mvp #33

clawbot referenced this issue

2026-08-07 18:07:44 +02:00

1.0/mvp #33

Sign in to join this conversation.