No message after saving, deleting, activating or signing out #383

Closed
opened 2026-10-01 22:06:18 +02:00 by clawbot · 2 comments
Collaborator

Owner's request, #377 (chat, 2026-10-01):

audit the whole app for stupid cases of missing functionality or basic things like this (like the stats panel at the top that i requested).

What is missing: most actions reload the page with no message saying what happened. That covers creating a webhook, saving a webhook or a target, adding or deleting an entrypoint or a target, activating or deactivating one, deleting a webhook, and signing out. In the audit, deleting a webhook landed on the webhook list with nothing to say it had worked. Deactivating a target changed only a small badge in its row. Only replay, resubmit and the password change report what they did (replayOutcome in internal/handlers/delivery_replay.go, resubmitOutcome in internal/handlers/event_resubmit.go, and the messages on the profile page).

Definition of done:

  • Each action listed above lands on its page with a one-line message saying what was done, for example "Webhook deleted.", "Target deactivated." or "Signed out.".
  • The message travels the way replay's does today: a fixed code in the redirect URL, mapped to fixed text. Nothing the user typed is echoed from the URL.
  • One template partial shows these messages, and the replay and resubmit messages too, on every page.
  • Tests: each action's redirect carries its code, and each page shows the message.

PRIORITY: from the owner's audit request of 1 October (#377), in the tier of #367 to #376.

Model: opus-5-5

Owner's request, https://git.eeqj.de/sneak/webhooker/issues/377 (chat, 2026-10-01): > audit the whole app for stupid cases of missing functionality or basic things like this (like the stats panel at the top that i requested). What is missing: most actions reload the page with no message saying what happened. That covers creating a webhook, saving a webhook or a target, adding or deleting an entrypoint or a target, activating or deactivating one, deleting a webhook, and signing out. In the audit, deleting a webhook landed on the webhook list with nothing to say it had worked. Deactivating a target changed only a small badge in its row. Only replay, resubmit and the password change report what they did (`replayOutcome` in `internal/handlers/delivery_replay.go`, `resubmitOutcome` in `internal/handlers/event_resubmit.go`, and the messages on the profile page). Definition of done: - Each action listed above lands on its page with a one-line message saying what was done, for example "Webhook deleted.", "Target deactivated." or "Signed out.". - The message travels the way replay's does today: a fixed code in the redirect URL, mapped to fixed text. Nothing the user typed is echoed from the URL. - One template partial shows these messages, and the replay and resubmit messages too, on every page. - Tests: each action's redirect carries its code, and each page shows the message. PRIORITY: from the owner's audit request of 1 October (https://git.eeqj.de/sneak/webhooker/issues/377), in the tier of https://git.eeqj.de/sneak/webhooker/issues/367 to https://git.eeqj.de/sneak/webhooker/issues/376. Model: opus-5-5
clawbot self-assigned this 2026-10-01 22:06:18 +02:00
Author
Collaborator

Plan. The issue body is the brief. Each listed action redirects with a fixed message code in the URL, the way replay does today; one map turns codes into fixed text, and anything unknown shows nothing, so nothing typed by a user is ever echoed. One template partial, included in the page layout, shows the message on every page, and the replay and resubmit messages move onto it so there is one way to show them. Signing out lands on the sign-in page with "Signed out." Tests check each action's redirect code and that each page shows its message.

Model: opus-5-5

Plan. The issue body is the brief. Each listed action redirects with a fixed message code in the URL, the way replay does today; one map turns codes into fixed text, and anything unknown shows nothing, so nothing typed by a user is ever echoed. One template partial, included in the page layout, shows the message on every page, and the replay and resubmit messages move onto it so there is one way to show them. Signing out lands on the sign-in page with "Signed out." Tests check each action's redirect code and that each page shows its message. Model: opus-5-5
Author
Collaborator

Built in #420. Every action listed above now lands on its page with a one-line notice, such as "Webhook deleted.", "Target deactivated." or "Signed out.". The redirect carries a fixed code that maps to fixed text, and an unknown code shows nothing. One partial in the page layout shows the notice on every page, and replay and resubmit now use the same codes and partial.

  • Judgement call: an error page shows no notice, even when its URL carries a code.
  • Judgement call: the notice sits above each page's own content, so on the event log it now appears above the page title.

Model: opus-5-5

Built in https://git.eeqj.de/sneak/webhooker/pulls/420. Every action listed above now lands on its page with a one-line notice, such as "Webhook deleted.", "Target deactivated." or "Signed out.". The redirect carries a fixed code that maps to fixed text, and an unknown code shows nothing. One partial in the page layout shows the notice on every page, and replay and resubmit now use the same codes and partial. - Judgement call: an error page shows no notice, even when its URL carries a code. - Judgement call: the notice sits above each page's own content, so on the event log it now appears above the page title. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/webhooker#383