Remove globals.Buildarch from codebase #31

clawbot · 2026-03-04T01:28:04+01:00

clawbot commented

2026-03-04 01:28:04 +01:00

Remove the Buildarch field from the globals package and all references throughout the codebase.

Changes:

Removed Buildarch package-level var and struct field from internal/globals/globals.go
Removed Buildarch from the New() constructor
Removed globals.Buildarch = runtime.GOARCH and unused runtime import from cmd/webhooker/main.go
Removed buildarch from logger startup output in internal/logger/logger.go
Removed all Buildarch test setup and assertions from globals, logger, database, and webhook_db_manager tests

All tests pass, make check passes, docker build . succeeds.

closes issue #30

Remove the `Buildarch` field from the globals package and all references throughout the codebase. **Changes:** - Removed `Buildarch` package-level var and struct field from `internal/globals/globals.go` - Removed `Buildarch` from the `New()` constructor - Removed `globals.Buildarch = runtime.GOARCH` and unused `runtime` import from `cmd/webhooker/main.go` - Removed `buildarch` from logger startup output in `internal/logger/logger.go` - Removed all `Buildarch` test setup and assertions from globals, logger, database, and webhook_db_manager tests All tests pass, `make check` passes, `docker build .` succeeds. closes [issue #30](https://git.eeqj.de/sneak/webhooker/issues/30)

clawbot added 1 commit 2026-03-04 01:28:04 +01:00

remove globals.Buildarch from codebase

check / check (push) Successful in 6s

Details

fd2c2d62dd

Remove the Buildarch field from the globals package variable, struct,
and constructor. Remove all references in main.go (including the
runtime import), logger startup output, and test setup across globals,
logger, database, and webhook_db_manager packages.

closes #30

clawbot added the

bot

label 2026-03-04 01:28:52 +01:00

clawbot commented

2026-03-04 01:30:39 +01:00

✅ Review: PASS

Clean removal of Buildarch from the codebase. Verified:

Complete removal: grep -r "Buildarch\|buildarch\|BUILDARCH" --include="*.go" returns nothing
No orphaned imports: runtime import correctly removed from cmd/webhooker/main.go
No Makefile/Dockerfile ldflags references to Buildarch
No README references to Buildarch
Tests pass: docker build . succeeds (which runs make check — formatting, linting, tests)
Single clean commit: remove globals.Buildarch from codebase

All 7 files correctly updated. No logic changes, just dead code removal as intended.

Labeling merge-ready and assigning to @sneak for final merge.

## ✅ Review: PASS Clean removal of `Buildarch` from the codebase. Verified: - **Complete removal**: `grep -r "Buildarch\|buildarch\|BUILDARCH" --include="*.go"` returns nothing - **No orphaned imports**: `runtime` import correctly removed from `cmd/webhooker/main.go` - **No Makefile/Dockerfile ldflags references** to Buildarch - **No README references** to Buildarch - **Tests pass**: `docker build .` succeeds (which runs `make check` — formatting, linting, tests) - **Single clean commit**: `remove globals.Buildarch from codebase` All 7 files correctly updated. No logic changes, just dead code removal as intended. Labeling `merge-ready` and assigning to @sneak for final merge.

clawbot added

merge-ready

and removed

bot

labels 2026-03-04 01:30:47 +01:00

sneak was assigned by clawbot

2026-03-04 01:30:53 +01:00

sneak merged commit a51e863017 into main

2026-03-04 12:07:58 +01:00

sneak deleted branch fix/issue-30-remove-buildarch

2026-03-04 12:07:58 +01:00

sneak referenced this issue from a commit