Describe code in its own terms, not by an earlier build's data (closes #522)
check / check (push) Waiting to run

Several comments justified code by what an earlier build would have
left in a database or on disk. Each now says what the code does:
reserveSQLiteFile sets the mode on every open whoever created the
file, and expired treats a session lacking a deadline's timestamp as
expired. The comments on retention, resubmitted events, archive
pruning, target headers, the redactor and the delivery result view
drop their mentions of older rows. parseMaxRetries loses its
paragraph on targets saved before the ceiling existed, and neither
BeforeSave nor retentionCutoff cites a migration. Comments only.

Model: opus-5-5
This commit was merged in pull request #524.
This commit is contained in:
2026-10-13 09:57:24 +02:00
parent 267d5b12f2
commit 373a2f828d
10 changed files with 22 additions and 35 deletions
+3 -4
View File
@@ -441,10 +441,9 @@ func (s *Session) Regenerate(
//
// Whichever comes first ends the session.
//
// A session that claims to be authenticated but carries no
// timestamps predates this check; it is treated as expired so the
// user re-authenticates rather than being granted an unbounded
// session.
// A session that claims to be authenticated but lacks the timestamp
// a deadline is measured from is treated as expired, so the user
// re-authenticates rather than being granted an unbounded session.
func (s *Session) expired(sess *sessions.Session) bool {
now := s.now()