sneak/webhooker
1
0
Fork 0
Code Issues 8 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove dead DevAdminUsername/Password config (closes #22)

Browse Source 
Remove DevAdminUsername and DevAdminPassword fields from the Config
struct and their loading code. These fields were never referenced
anywhere else in the codebase.
This commit is contained in:
clawbot 2026-03-01 16:36:36 -08:00
parent 36824046fb
commit 348fd81fe6
2 changed files with 24 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
internal/config/config.go
View File

@ -36,20 +36,18 @@ type ConfigParams struct {
} }
type Config struct { type Config struct {
DBURL string DBURL string
Debug bool Debug bool
MaintenanceMode bool MaintenanceMode bool
DevelopmentMode bool DevelopmentMode bool
DevAdminUsername string Environment string
DevAdminPassword string MetricsPassword string
Environment string MetricsUsername string
MetricsPassword string Port int
MetricsUsername string SentryDSN string
Port int SessionKey string
SentryDSN string params *ConfigParams
SessionKey string log *slog.Logger
params *ConfigParams
log *slog.Logger
} }
// IsDev returns true if running in development environment // IsDev returns true if running in development environment
@ -117,20 +115,18 @@ func New(lc fx.Lifecycle, params ConfigParams) (*Config, error) {
// Load configuration values — env vars take precedence over config.yaml // Load configuration values — env vars take precedence over config.yaml
s := &Config{ s := &Config{
DBURL: envString("DBURL", "dburl"), DBURL: envString("DBURL", "dburl"),
Debug: envBool("DEBUG", "debug"), Debug: envBool("DEBUG", "debug"),
MaintenanceMode: envBool("MAINTENANCE_MODE", "maintenanceMode"), MaintenanceMode: envBool("MAINTENANCE_MODE", "maintenanceMode"),
DevelopmentMode: envBool("DEVELOPMENT_MODE", "developmentMode"), DevelopmentMode: envBool("DEVELOPMENT_MODE", "developmentMode"),
DevAdminUsername: envString("DEV_ADMIN_USERNAME", "devAdminUsername"), Environment: environment,
DevAdminPassword: envString("DEV_ADMIN_PASSWORD", "devAdminPassword"), MetricsUsername: envString("METRICS_USERNAME", "metricsUsername"),
Environment: environment, MetricsPassword: envString("METRICS_PASSWORD", "metricsPassword"),
MetricsUsername: envString("METRICS_USERNAME", "metricsUsername"), Port: envInt("PORT", "port", 8080),
MetricsPassword: envString("METRICS_PASSWORD", "metricsPassword"), SentryDSN: envSecretString("SENTRY_DSN", "sentryDSN"),
Port: envInt("PORT", "port", 8080), SessionKey: envSecretString("SESSION_KEY", "sessionKey"),
SentryDSN: envSecretString("SENTRY_DSN", "sentryDSN"), log: log,
SessionKey: envSecretString("SESSION_KEY", "sessionKey"), params: &params,
log: log,
params: &params,
} }
// Validate database URL // Validate database URL

2
internal/config/config_test.go
View File

@ -53,8 +53,6 @@ configDefaults:
environment: dev environment: dev
metricsUsername: "" metricsUsername: ""
metricsPassword: "" metricsPassword: ""
devAdminUsername: ""
devAdminPassword: ""
` `
return afero.WriteFile(fs, "config.yaml", []byte(configYAML), 0644) return afero.WriteFile(fs, "config.yaml", []byte(configYAML), 0644)
} }