DevAdminUsername/DevAdminPassword config fields are dead code #22
Labels
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sneak/webhooker#22
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Bug
internal/config/config.goreadsDEV_ADMIN_USERNAMEandDEV_ADMIN_PASSWORDfrom environment variables:But these values are never used anywhere in the codebase. The admin user is always created with a randomly generated password in
database.go:No code ever reads
Config.DevAdminUsernameorConfig.DevAdminPassword.Fix
Either:
database.goto set a deterministic admin password in dev mode (which would improve DX)Option 2 example:
Category
Should-fix. Dead code adds confusion.