All checks were successful
check / check (push) Successful in 5s
Updates golangci-lint to v2.12.2 everywhere it is pinned and installs the canonical `.golangci.yml`, then remediates every finding the new linter/config surfaces so `make check` is green. ## Version bump - `Dockerfile` lint stage: `golangci/golangci-lint:v2.11.3-alpine` -> `v2.12.2-alpine` (digest-pinned, date comment updated) - `Makefile` `deps` target: `go install` moved from the old v1 module path at `@latest` to the pinned `github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2` - `.golangci.yml` replaced with the canonical config (v2 schema; settings under `linters.settings` so the thresholds actually apply; `default: all` with the standard six disables) - `script/bootstrap` installs golangci-lint via the system package manager and carries no version pin, so it is unchanged - CI (`.gitea/workflows/check.yml`) only runs `script/cibuild`, so it needed no change ## Lint remediation The canonical config surfaced ~3,300 findings across 56k lines. All are fixed, behavior-preserving; incorporates and supersedes the per-package mechanical passes already merged to `main` (refs #61). Highlights: - `err113`: dynamic errors replaced with package sentinels + `%w` wrapping; comparisons via `errors.Is` - `goprintffuncname`: printf-style helpers renamed with an `f` suffix (`ui.Writer` message methods, `cli.ReportErrorf`, `database.Fatalf`) and all call sites updated - `revive` stutter renames: `blob.Handler`, `blob.WithReader`, `blob.ChunkPosition`, `storage.URL`, `storage.Info`; missing doc comments added - `contextcheck`/`noctx`: `context.Context` threaded through `blob.Packer` and the scanner call sites; context-aware `exec`/`sql` variants - `funlen`/`cyclop`/`gocognit`/`dupl`: oversized and duplicated functions split into focused helpers (production and test code) - tests: `t.Parallel()` added where safe (global logger init kept in the serial phase for `-race`), `t.TempDir()`/`t.Helper()` adopted, several suites converted to external test packages - `gosec`: bounded integer conversions, `ReadHeaderTimeout` on the test HTTP server; remaining warnings suppressed per-site with justifications - remaining `nolint` directives are rare, targeted, and each carries a reason (e.g. `nilnil` not-found contract in the repository layer, fx module globals, on-disk snake_case struct tags) - removed the deprecated `log.LogOptions` alias (callers migrated to `log.Options`) `make check` (tests with `-race`, lint, fmt-check) passes. Co-authored-by: sneak <sneak@sneak.berlin> Reviewed-on: #62 Co-authored-by: clawbot <clawbot@noreply.example.org> Co-committed-by: clawbot <clawbot@noreply.example.org>
195 lines
4.0 KiB
Go
195 lines
4.0 KiB
Go
package database
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"errors"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"sneak.berlin/go/vaultik/internal/log"
|
|
)
|
|
|
|
// ChunkRepository provides access to the chunks table, which tracks
|
|
// content-defined chunks by hash and size.
|
|
type ChunkRepository struct {
|
|
db *DB
|
|
}
|
|
|
|
// NewChunkRepository creates a ChunkRepository backed by db.
|
|
func NewChunkRepository(db *DB) *ChunkRepository {
|
|
return &ChunkRepository{db: db}
|
|
}
|
|
|
|
// Create inserts a chunk row (idempotently), using tx when non-nil.
|
|
func (r *ChunkRepository) Create(ctx context.Context, tx *sql.Tx, chunk *Chunk) error {
|
|
query := `
|
|
INSERT INTO chunks (chunk_hash, size)
|
|
VALUES (?, ?)
|
|
ON CONFLICT(chunk_hash) DO NOTHING
|
|
`
|
|
|
|
var err error
|
|
if tx != nil {
|
|
_, err = tx.ExecContext(ctx, query, chunk.ChunkHash, chunk.Size)
|
|
} else {
|
|
_, err = r.db.ExecWithLog(ctx, query, chunk.ChunkHash, chunk.Size)
|
|
}
|
|
|
|
if err != nil {
|
|
return fmt.Errorf("inserting chunk: %w", err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// GetByHash returns the chunk with the given hash, or nil if it is not
|
|
// known to the index.
|
|
func (r *ChunkRepository) GetByHash(ctx context.Context, hash string) (*Chunk, error) {
|
|
query := `
|
|
SELECT chunk_hash, size
|
|
FROM chunks
|
|
WHERE chunk_hash = ?
|
|
`
|
|
|
|
var chunk Chunk
|
|
|
|
err := r.db.conn.QueryRowContext(ctx, query, hash).Scan(
|
|
&chunk.ChunkHash,
|
|
&chunk.Size,
|
|
)
|
|
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
return nil, nil //nolint:nilnil // nil,nil signals not-found; callers check nil
|
|
}
|
|
|
|
if err != nil {
|
|
return nil, fmt.Errorf("querying chunk: %w", err)
|
|
}
|
|
|
|
return &chunk, nil
|
|
}
|
|
|
|
// GetByHashes returns the chunks whose hashes appear in hashes, ordered by
|
|
// chunk hash. Unknown hashes are silently omitted from the result.
|
|
func (r *ChunkRepository) GetByHashes(
|
|
ctx context.Context, hashes []string,
|
|
) ([]*Chunk, error) {
|
|
if len(hashes) == 0 {
|
|
return nil, nil
|
|
}
|
|
|
|
query := `
|
|
SELECT chunk_hash, size
|
|
FROM chunks
|
|
WHERE chunk_hash IN (`
|
|
|
|
args := make([]any, len(hashes))
|
|
|
|
var querySb75 strings.Builder
|
|
|
|
for i, hash := range hashes {
|
|
if i > 0 {
|
|
querySb75.WriteString(", ")
|
|
}
|
|
|
|
querySb75.WriteString("?")
|
|
|
|
args[i] = hash
|
|
}
|
|
|
|
query += querySb75.String() //nolint:gosec // G202: appends "?" placeholders only
|
|
|
|
query += ") ORDER BY chunk_hash"
|
|
|
|
rows, err := r.db.conn.QueryContext(ctx, query, args...)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("querying chunks: %w", err)
|
|
}
|
|
defer CloseRows(rows)
|
|
|
|
var chunks []*Chunk
|
|
|
|
for rows.Next() {
|
|
var chunk Chunk
|
|
|
|
err := rows.Scan(
|
|
&chunk.ChunkHash,
|
|
&chunk.Size,
|
|
)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("scanning chunk: %w", err)
|
|
}
|
|
|
|
chunks = append(chunks, &chunk)
|
|
}
|
|
|
|
return chunks, rows.Err()
|
|
}
|
|
|
|
// ListUnpacked returns up to limit chunks that are not yet stored in any
|
|
// blob, ordered by chunk hash.
|
|
func (r *ChunkRepository) ListUnpacked(
|
|
ctx context.Context, limit int,
|
|
) ([]*Chunk, error) {
|
|
query := `
|
|
SELECT c.chunk_hash, c.size
|
|
FROM chunks c
|
|
LEFT JOIN blob_chunks bc ON c.chunk_hash = bc.chunk_hash
|
|
WHERE bc.chunk_hash IS NULL
|
|
ORDER BY c.chunk_hash
|
|
LIMIT ?
|
|
`
|
|
|
|
rows, err := r.db.conn.QueryContext(ctx, query, limit)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("querying unpacked chunks: %w", err)
|
|
}
|
|
defer CloseRows(rows)
|
|
|
|
var chunks []*Chunk
|
|
|
|
for rows.Next() {
|
|
var chunk Chunk
|
|
|
|
err := rows.Scan(
|
|
&chunk.ChunkHash,
|
|
&chunk.Size,
|
|
)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("scanning chunk: %w", err)
|
|
}
|
|
|
|
chunks = append(chunks, &chunk)
|
|
}
|
|
|
|
return chunks, rows.Err()
|
|
}
|
|
|
|
// DeleteOrphaned deletes chunks that are not referenced by any file or blob
|
|
func (r *ChunkRepository) DeleteOrphaned(ctx context.Context) error {
|
|
query := `
|
|
DELETE FROM chunks
|
|
WHERE NOT EXISTS (
|
|
SELECT 1 FROM file_chunks
|
|
WHERE file_chunks.chunk_hash = chunks.chunk_hash
|
|
)
|
|
AND NOT EXISTS (
|
|
SELECT 1 FROM blob_chunks
|
|
WHERE blob_chunks.chunk_hash = chunks.chunk_hash
|
|
)
|
|
`
|
|
|
|
result, err := r.db.ExecWithLog(ctx, query)
|
|
if err != nil {
|
|
return fmt.Errorf("deleting orphaned chunks: %w", err)
|
|
}
|
|
|
|
rowsAffected, _ := result.RowsAffected()
|
|
if rowsAffected > 0 {
|
|
log.Debug("Deleted orphaned chunks", "count", rowsAffected)
|
|
}
|
|
|
|
return nil
|
|
}
|