sneak
b960ca37a8
Some checks failed
check / check (pull_request) Failing after 59s
Seven findings remain that cannot be fixed without either lying about the code or making a repo-wide naming decision, so each carries a per-site //nolint directive with its justification. gosec G115 (internal/log, internal/ui): term.IsTerminal takes an int and os.File.Fd() returns a uintptr, so the conversion is forced by the API. A file descriptor always fits in an int on every platform Go supports, and a closed file yields -1, which IsTerminal reports as not a terminal. gosec G703 (internal/vaultik/verify.go): the removed path comes from os.CreateTemp a few lines above and never from user input. G703's taint analysis treats every path derived from an *os.File as tainted, so there is no code shape that clears it. revive var-naming (internal/log, internal/crypto, internal/types): fixing these means renaming packages across the whole codebase, which is the repo owner's call, not a lint fix. Neither stdlib log nor stdlib crypto is imported anywhere in the repo, so nothing is actually shadowed today. The rename decision is tracked in issue #76. revive reports a package-name failure only once per package directory, on whichever file it happens to lint first, so every file of the affected packages carries the directive and lists nolintlint alongside revive so the ones that lose the race are not reported as unused. With this, make check exits 0 under the canonical .golangci.yml (sha256 021cc83f4e6fc7c31b95b34b846723dfcf20b66b7baeea1dc40406e643346bcb, unmodified), which also unblocks issue #59. TODO.md: record this work, correct the earlier entry that claimed make check was green when lint was still red, and move the next step on to the stale-branch triage.
3.5 KiB
3.5 KiB