sneak
7ae470e530
Fix every finding surfaced by the canonical .golangci.yml with golangci-lint v2.12.2 (refs #61), behavior-preserving throughout: - err113: dynamic errors replaced with package-level sentinels and %w wrapping; direct comparisons converted to errors.Is - goprintffuncname: printf-style helpers renamed with an f suffix (ui.Writer message methods, cli.ReportErrorf, database.Fatalf, vaultik stdoutf) and all call sites updated - revive: stuttering type names renamed (blob.Handler, blob.WithReader, blob.ChunkPosition, storage.URL, storage.Info), doc comments added, unused parameters blanked, package comments added - contextcheck/noctx: ctx threaded through blob.Packer (AddChunk/Flush/FinalizeBlob/PackChunks) and scanner call sites; context-aware exec and sql variants used - funlen/cyclop/gocognit/nestif/dupl: oversized or duplicated functions split into focused helpers across production and test code - paralleltest/tparallel/thelper/usetesting/testpackage: tests parallelized where safe (global log.Initialize kept in the serial phase), helpers marked, t.TempDir adopted, external test packages where only exported API is used - gosec: integer conversions clamped or justified, header timeouts added, remaining findings suppressed with per-site justifications - mnd/goconst/lll/wsl_v5/nlreturn/noinlineerr/errcheck and other mechanical findings fixed directly Remove the deprecated log.LogOptions alias (callers migrated to log.Options). make check is green.
81 lines
2.5 KiB
Go
81 lines
2.5 KiB
Go
package blobgen_test
|
|
|
|
import (
|
|
"bytes"
|
|
"crypto/rand"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"sneak.berlin/go/vaultik/internal/blobgen"
|
|
)
|
|
|
|
// testRecipient is a static age recipient for tests.
|
|
const testRecipient = "age1cplgrwj77ta54dnmydvvmzn64ltk83ankxl5sww04mrtmu62kv3s89gmvv"
|
|
|
|
// TestCompressStreamNoDoubleClose is a regression test for issue #28.
|
|
// It verifies that CompressStream does not panic or return an error due to
|
|
// double-closing the underlying blobgen.Writer. Before the fix in PR #33,
|
|
// the explicit Close() on the happy path combined with defer Close() would
|
|
// cause a double close.
|
|
func TestCompressStreamNoDoubleClose(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
input := []byte("regression test data for issue #28 double-close fix")
|
|
|
|
var buf bytes.Buffer
|
|
|
|
written, hash, err := blobgen.CompressStream(
|
|
&buf, bytes.NewReader(input), 3, []string{testRecipient})
|
|
require.NoError(t, err, "CompressStream should not return an error")
|
|
assert.Positive(t, written, "expected bytes written > 0")
|
|
assert.NotEmpty(t, hash, "expected non-empty hash")
|
|
assert.Positive(t, buf.Len(), "expected non-empty output")
|
|
}
|
|
|
|
// TestCompressStreamLargeInput exercises CompressStream with a larger payload
|
|
// to ensure no double-close issues surface under heavier I/O.
|
|
func TestCompressStreamLargeInput(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
data := make([]byte, 512*1024) // 512 KB
|
|
_, err := rand.Read(data)
|
|
require.NoError(t, err)
|
|
|
|
var buf bytes.Buffer
|
|
|
|
written, hash, err := blobgen.CompressStream(
|
|
&buf, bytes.NewReader(data), 3, []string{testRecipient})
|
|
require.NoError(t, err)
|
|
assert.Positive(t, written)
|
|
assert.NotEmpty(t, hash)
|
|
}
|
|
|
|
// TestCompressStreamEmptyInput verifies CompressStream handles empty input
|
|
// without double-close issues.
|
|
func TestCompressStreamEmptyInput(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
var buf bytes.Buffer
|
|
|
|
_, hash, err := blobgen.CompressStream(
|
|
&buf, strings.NewReader(""), 3, []string{testRecipient})
|
|
require.NoError(t, err)
|
|
assert.NotEmpty(t, hash)
|
|
}
|
|
|
|
// TestCompressDataNoDoubleClose mirrors the stream test for CompressData,
|
|
// ensuring the explicit Close + error-path Close pattern is also safe.
|
|
func TestCompressDataNoDoubleClose(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
input := []byte("CompressData regression test for double-close")
|
|
|
|
result, err := blobgen.CompressData(input, 3, []string{testRecipient})
|
|
require.NoError(t, err)
|
|
assert.Positive(t, result.CompressedSize)
|
|
assert.Equal(t, result.UncompressedSize, int64(len(input)))
|
|
assert.NotEmpty(t, result.SHA256)
|
|
}
|