Let prune delete old .partial uploads and remote info count them (closes #466) #474

Open
clawbot wants to merge 1 commits from issue-466-prune-partial-uploads into next
pull from: issue-466-prune-partial-uploads
Collaborator

Closes #466

prune now deletes a .partial object a killed upload left under metadata/ or blobs/ once it is older than prune_grace_period, as it does an unreferenced blob. remote info counts such objects on a "Partial uploads" line and in partial_upload_count / partial_upload_size.

What changed:

  • The storage interface's DeletePartialUploads is replaced by ListPartialUploads, which returns key, size and time per object. Delete removes one by its listed key on both the file and rclone backends. S3 lists none.
  • prune keeps a newer one, or one of unknown age, and says so. It states their count and total size before the confirmation prompt. --json gains partial_uploads_deleted, partial_uploads_failed and partial_uploads_too_new. A failed delete makes it exit non-zero, as for blobs.
  • remote nuke lists .partial objects along with the rest and deletes them one by one. Any it cannot delete now appear in its "still on the backup destination store" list; before, the first failure aborted it.
  • The prune prompt line is now built from whichever kinds were found, so a third kind does not need more cases.

README, docs/ and the example config describe the new behaviour.

Model: opus-5-5

Closes https://git.eeqj.de/sneak/vaultik/issues/466 `prune` now deletes a `.partial` object a killed upload left under `metadata/` or `blobs/` once it is older than `prune_grace_period`, as it does an unreferenced blob. `remote info` counts such objects on a "Partial uploads" line and in `partial_upload_count` / `partial_upload_size`. What changed: - The storage interface's `DeletePartialUploads` is replaced by `ListPartialUploads`, which returns key, size and time per object. `Delete` removes one by its listed key on both the file and rclone backends. S3 lists none. - `prune` keeps a newer one, or one of unknown age, and says so. It states their count and total size before the confirmation prompt. `--json` gains `partial_uploads_deleted`, `partial_uploads_failed` and `partial_uploads_too_new`. A failed delete makes it exit non-zero, as for blobs. - `remote nuke` lists `.partial` objects along with the rest and deletes them one by one. Any it cannot delete now appear in its "still on the backup destination store" list; before, the first failure aborted it. - The prune prompt line is now built from whichever kinds were found, so a third kind does not need more cases. README, `docs/` and the example config describe the new behaviour. Model: opus-5-5
clawbot added the needs-review label 2026-11-19 08:31:22 +01:00
clawbot self-assigned this 2026-11-19 08:31:22 +01:00
clawbot added 1 commit 2026-11-19 08:31:22 +01:00
A killed upload leaves a `.partial` object that only remote nuke
removed, and that remote info never showed.

The storage interface's DeletePartialUploads becomes ListPartialUploads,
which returns each such object's key, size and time; Delete removes it.
prune deletes those under metadata/ and blobs/ once older than
prune_grace_period, and reports kept, deleted and failed counts. remote
info counts them on their own line and in --json. remote nuke lists and
deletes them like any other object, and now names any it could not
delete.

Model: opus-5-5
Some checks are pending
check / check (push) Waiting to run
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin issue-466-prune-partial-uploads:issue-466-prune-partial-uploads
git checkout issue-466-prune-partial-uploads
Sign in to join this conversation.