config set storage_url accepted malformed rclone:// values (no remote name, parameters in the remote name, a query parameter) that every command then refused. The config only checked the URL's prefix, because config could not import the parser from storage, which imports config.
The parser moves from internal/storage/url.go to a new package, internal/storageurl, which config and storage both import. storage.ParseStorageURL becomes storageurl.Parse; the scheme names are exported for storage.
validateStorageURL calls storageurl.Parse on every storage_url, then requires the S3 keys for s3:// as before.
config set tests cover the three values from the issue.
Judgement call: the check now covers every scheme, not only rclone://, since one parser call replaced the per-scheme prefix checks. An s3:// URL the parser rejects (a credential in it, an unknown parameter, no bucket) now fails at load instead of when a command opens the destination. The file:// and unknown-scheme errors now carry the parser's wording.
Model: opus-5-5
closes https://git.eeqj.de/sneak/vaultik/issues/468
`config set storage_url` accepted malformed `rclone://` values (no remote name, parameters in the remote name, a query parameter) that every command then refused. The config only checked the URL's prefix, because `config` could not import the parser from `storage`, which imports `config`.
- The parser moves from `internal/storage/url.go` to a new package, `internal/storageurl`, which `config` and `storage` both import. `storage.ParseStorageURL` becomes `storageurl.Parse`; the scheme names are exported for `storage`.
- `validateStorageURL` calls `storageurl.Parse` on every `storage_url`, then requires the S3 keys for `s3://` as before.
- `config set` tests cover the three values from the issue.
Judgement call: the check now covers every scheme, not only `rclone://`, since one parser call replaced the per-scheme prefix checks. An `s3://` URL the parser rejects (a credential in it, an unknown parameter, no bucket) now fails at load instead of when a command opens the destination. The `file://` and unknown-scheme errors now carry the parser's wording.
Model: opus-5-5
config set accepted rclone:// values that every command then refused:
no remote name, parameters in the remote name, a query parameter. The
config only checked the URL's prefix, because config could not import
the parser from storage, which imports config.
The parser moves from internal/storage to a new package,
internal/storageurl, that both import. ParseStorageURL becomes
storageurl.Parse. Loading the config now runs it on every storage_url,
so config set refuses such a value and leaves the file unchanged.
Model: opus-5-5
clawbot
self-assigned this 2026-11-19 08:31:14 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
closes #468
config set storage_urlaccepted malformedrclone://values (no remote name, parameters in the remote name, a query parameter) that every command then refused. The config only checked the URL's prefix, becauseconfigcould not import the parser fromstorage, which importsconfig.internal/storage/url.goto a new package,internal/storageurl, whichconfigandstorageboth import.storage.ParseStorageURLbecomesstorageurl.Parse; the scheme names are exported forstorage.validateStorageURLcallsstorageurl.Parseon everystorage_url, then requires the S3 keys fors3://as before.config settests cover the three values from the issue.Judgement call: the check now covers every scheme, not only
rclone://, since one parser call replaced the per-scheme prefix checks. Ans3://URL the parser rejects (a credential in it, an unknown parameter, no bucket) now fails at load instead of when a command opens the destination. Thefile://and unknown-scheme errors now carry the parser's wording.Model: opus-5-5
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.