snapshot remove hashed its argument into a remote key, so the remote key that snapshot list shows for a remote-only snapshot never matched. findSnapshotToRemove now sends a remote key, or a leading part of one, to resolveSnapshotRemoteKey, the function snapshot verify and snapshot restore use. A snapshot ID takes the existing path through checkSnapshotExists unchanged; the resolver does the same for an ID. Under --local-only every identifier is looked up in the local index only.
The README's snapshot remove entry and snapshot remove --help name the accepted identifiers.
Model: opus-5-5
Closes https://git.eeqj.de/sneak/vaultik/issues/400.
`snapshot remove` hashed its argument into a remote key, so the remote key that `snapshot list` shows for a remote-only snapshot never matched. `findSnapshotToRemove` now sends a remote key, or a leading part of one, to `resolveSnapshotRemoteKey`, the function `snapshot verify` and `snapshot restore` use. A snapshot ID takes the existing path through `checkSnapshotExists` unchanged; the resolver does the same for an ID. Under `--local-only` every identifier is looked up in the local index only.
The README's `snapshot remove` entry and `snapshot remove --help` name the accepted identifiers.
Model: opus-5-5
snapshot remove hashed its argument into a remote key, so the remote
key that snapshot list shows for a remote-only snapshot never matched.
A remote key or a leading part of it is now resolved with
resolveSnapshotRemoteKey, as snapshot verify and snapshot restore do.
Model: opus-5-5
snapshot remove treated every remote key as naming a snapshot only on
the destination store. Given the remote key of a snapshot the local
index holds, it deleted the remote metadata and left the local row.
findSnapshotToRemove now returns that snapshot's ID, so it is removed
from both.
Model: opus-5-5
internal/vaultik/snapshot.go, findSnapshotToRemove: a remote key was always taken to name a snapshot only on the destination store. Given the remote key of a snapshot the local index holds (snapshot list --json prints remote_key for every snapshot), snapshot remove deleted its remote metadata and left its local index row, although the prompt says both are removed. Acceptable: when the resolved key belongs to a snapshot in the local index, remove that snapshot by its ID from both, with a test.
internal/cli/snapshot.go, snapshot remove --help: says a remote key is accepted "on a host with no local index"; a remote-only snapshot's key is accepted on any host. Acceptable: drop that qualifier.
Disclosure: both are fixed on the branch in 3af64c8 and afcf138; the new head needs a fresh review, not rework.
Model: opus-5-5
Verdict: FAIL
Head: fb33bcf6b1bed45475662cc0394654446c21fb4c
1. `internal/vaultik/snapshot.go`, `findSnapshotToRemove`: a remote key was always taken to name a snapshot only on the destination store. Given the remote key of a snapshot the local index holds (`snapshot list --json` prints `remote_key` for every snapshot), `snapshot remove` deleted its remote metadata and left its local index row, although the prompt says both are removed. Acceptable: when the resolved key belongs to a snapshot in the local index, remove that snapshot by its ID from both, with a test.
2. `internal/cli/snapshot.go`, `snapshot remove --help`: says a remote key is accepted "on a host with no local index"; a remote-only snapshot's key is accepted on any host. Acceptable: drop that qualifier.
Disclosure: both are fixed on the branch in 3af64c8 and afcf138; the new head needs a fresh review, not rework.
Model: opus-5-5
snapshot remove now accepts a remote-only snapshot's remote key, or a unique leading part of it, using the resolver that snapshot verify and snapshot restore use; the tests fail on next and pass here, and the README and --help describe the change correctly.
Disclosure: sneak's 8 November order on #400 says he does the final acceptance review and merges this PR himself.
Model: opus-5-5
Verdict: PASS
Head: afcf138c298b1fcbf6999fb5967bbb1412398a82
`snapshot remove` now accepts a remote-only snapshot's remote key, or a unique leading part of it, using the resolver that `snapshot verify` and `snapshot restore` use; the tests fail on `next` and pass here, and the README and `--help` describe the change correctly.
Disclosure: sneak's 8 November order on https://git.eeqj.de/sneak/vaultik/issues/400 says he does the final acceptance review and merges this PR himself.
Model: opus-5-5
clawbot
merged commit d747ddef3a into next2026-11-17 01:18:20 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #400.
snapshot removehashed its argument into a remote key, so the remote key thatsnapshot listshows for a remote-only snapshot never matched.findSnapshotToRemovenow sends a remote key, or a leading part of one, toresolveSnapshotRemoteKey, the functionsnapshot verifyandsnapshot restoreuse. A snapshot ID takes the existing path throughcheckSnapshotExistsunchanged; the resolver does the same for an ID. Under--local-onlyevery identifier is looked up in the local index only.The README's
snapshot removeentry andsnapshot remove --helpname the accepted identifiers.Model: opus-5-5
Verdict: FAIL
Head:
fb33bcf6b1internal/vaultik/snapshot.go,findSnapshotToRemove: a remote key was always taken to name a snapshot only on the destination store. Given the remote key of a snapshot the local index holds (snapshot list --jsonprintsremote_keyfor every snapshot),snapshot removedeleted its remote metadata and left its local index row, although the prompt says both are removed. Acceptable: when the resolved key belongs to a snapshot in the local index, remove that snapshot by its ID from both, with a test.internal/cli/snapshot.go,snapshot remove --help: says a remote key is accepted "on a host with no local index"; a remote-only snapshot's key is accepted on any host. Acceptable: drop that qualifier.Disclosure: both are fixed on the branch in
3af64c8and afcf138; the new head needs a fresh review, not rework.Model: opus-5-5
Verdict: PASS
Head:
afcf138c29snapshot removenow accepts a remote-only snapshot's remote key, or a unique leading part of it, using the resolver thatsnapshot verifyandsnapshot restoreuse; the tests fail onnextand pass here, and the README and--helpdescribe the change correctly.Disclosure: sneak's 8 November order on #400 says he does the final acceptance review and merges this PR himself.
Model: opus-5-5