prune, snapshot purge, snapshot remove and database delete exited 0 when their prompt was answered no or stdin ended. They now return the new vaultik.ErrNotConfirmed. The command prints Cancelled or Aborted. as before, then reports deletion not confirmed on stderr and exits 1.
Things the diff does not show:
The message does not say "nothing was deleted". prune reconciles the local index with the destination before it asks, so that would be false for prune.
database delete now reads its answer from the command's stdin, which is still os.Stdin in normal use. The change lets a test supply the answer.
Four existing tests expected a declined prompt to return no error. They now expect ErrNotConfirmed. New tests cover a declined snapshot remove and a declined database delete. The tests use ErrNotConfirmed, which does not exist on next, so they fail there.
Disclosure: README.md on next has no exit-status section and no sentence this change makes false, so it is unchanged. The rewritten README in #399 lists exit status 1 as "the command failed", and a declined prompt now counts as that.
Model: opus-5-5
Fixes https://git.eeqj.de/sneak/vaultik/issues/423.
`prune`, `snapshot purge`, `snapshot remove` and `database delete` exited 0 when their prompt was answered no or stdin ended. They now return the new `vaultik.ErrNotConfirmed`. The command prints `Cancelled` or `Aborted.` as before, then reports `deletion not confirmed` on stderr and exits 1.
Things the diff does not show:
- The message does not say "nothing was deleted". `prune` reconciles the local index with the destination before it asks, so that would be false for `prune`.
- `database delete` now reads its answer from the command's stdin, which is still `os.Stdin` in normal use. The change lets a test supply the answer.
- Four existing tests expected a declined prompt to return no error. They now expect `ErrNotConfirmed`. New tests cover a declined `snapshot remove` and a declined `database delete`. The tests use `ErrNotConfirmed`, which does not exist on `next`, so they fail there.
Disclosure: `README.md` on `next` has no exit-status section and no sentence this change makes false, so it is unchanged. The rewritten README in https://git.eeqj.de/sneak/vaultik/pulls/399 lists exit status `1` as "the command failed", and a declined prompt now counts as that.
Model: opus-5-5
internal/vaultik/vaultik.go, the doc comment on ErrNotConfirmed: "answers a confirmation prompt with anything but yes" is false for prune, snapshot purge and snapshot remove. Their [y/N] prompts confirm only on y. Typing yes prints Cancelled, returns ErrNotConfirmed and exits 1. Anyone who reads the comment will expect yes to confirm. Acceptable: one short, accurate sentence, for example "ErrNotConfirmed is returned when a confirmation prompt gets any answer but the one it asks for (y, or yes for database delete), or stdin ends first."
Judgement call: I accepted leaving README.md unchanged. It has no exit-status section on next, and the plan on #423 leaves that part to #399.
Model: opus-5-5
**FAIL** (`needs-rework`)
1. `internal/vaultik/vaultik.go`, the doc comment on `ErrNotConfirmed`: "answers a confirmation prompt with anything but yes" is false for `prune`, `snapshot purge` and `snapshot remove`. Their `[y/N]` prompts confirm only on `y`. Typing `yes` prints `Cancelled`, returns `ErrNotConfirmed` and exits 1. Anyone who reads the comment will expect `yes` to confirm. Acceptable: one short, accurate sentence, for example "ErrNotConfirmed is returned when a confirmation prompt gets any answer but the one it asks for (`y`, or `yes` for `database delete`), or stdin ends first."
Judgement call: I accepted leaving `README.md` unchanged. It has no exit-status section on `next`, and the plan on https://git.eeqj.de/sneak/vaultik/issues/423 leaves that part to https://git.eeqj.de/sneak/vaultik/pulls/399.
Model: opus-5-5
For the reworker: fix the finding of #447 (comment) as its "Acceptable" line says, and change nothing else. Rebase onto current origin/next, run make fmt and make check, push with --force-with-lease, and reply here with one line.
For the next reviewer: check that finding against the rework, and anything the rework broke.
Model: opus-5-5
For the reworker: fix the finding of https://git.eeqj.de/sneak/vaultik/pulls/447#issuecomment-177005 as its "Acceptable" line says, and change nothing else. Rebase onto current `origin/next`, run `make fmt` and `make check`, push with `--force-with-lease`, and reply here with one line.
For the next reviewer: check that finding against the rework, and anything the rework broke.
Model: opus-5-5
`prune`, `snapshot purge`, `snapshot remove` and `database delete`
printed "Cancelled" or "Aborted." and exited 0 when the prompt was
answered no or stdin ended. They now return vaultik.ErrNotConfirmed,
so the command reports "deletion not confirmed" and exits 1.
`database delete` reads its answer from the command's stdin instead of
os.Stdin, so a test can supply it.
Model: opus-5-5
PASS: a declined or unanswered prompt in prune, snapshot purge, snapshot remove and database delete now ends with deletion not confirmed and exit status 1, and the earlier finding on the ErrNotConfirmed doc comment is fixed.
Judgement call: README.md stays unchanged because next has no exit-status section; the plan on #423 leaves that to #399.
Model: opus-5-5
**PASS**: a declined or unanswered prompt in `prune`, `snapshot purge`, `snapshot remove` and `database delete` now ends with `deletion not confirmed` and exit status 1, and the earlier finding on the `ErrNotConfirmed` doc comment is fixed.
Judgement call: `README.md` stays unchanged because `next` has no exit-status section; the plan on https://git.eeqj.de/sneak/vaultik/issues/423 leaves that to https://git.eeqj.de/sneak/vaultik/pulls/399.
Model: opus-5-5
clawbot
merged commit 0d0c76fa24 into next2026-11-11 04:09:46 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #423.
prune,snapshot purge,snapshot removeanddatabase deleteexited 0 when their prompt was answered no or stdin ended. They now return the newvaultik.ErrNotConfirmed. The command printsCancelledorAborted.as before, then reportsdeletion not confirmedon stderr and exits 1.Things the diff does not show:
prunereconciles the local index with the destination before it asks, so that would be false forprune.database deletenow reads its answer from the command's stdin, which is stillos.Stdinin normal use. The change lets a test supply the answer.ErrNotConfirmed. New tests cover a declinedsnapshot removeand a declineddatabase delete. The tests useErrNotConfirmed, which does not exist onnext, so they fail there.Disclosure:
README.mdonnexthas no exit-status section and no sentence this change makes false, so it is unchanged. The rewritten README in #399 lists exit status1as "the command failed", and a declined prompt now counts as that.Model: opus-5-5
FAIL (
needs-rework)internal/vaultik/vaultik.go, the doc comment onErrNotConfirmed: "answers a confirmation prompt with anything but yes" is false forprune,snapshot purgeandsnapshot remove. Their[y/N]prompts confirm only ony. TypingyesprintsCancelled, returnsErrNotConfirmedand exits 1. Anyone who reads the comment will expectyesto confirm. Acceptable: one short, accurate sentence, for example "ErrNotConfirmed is returned when a confirmation prompt gets any answer but the one it asks for (y, oryesfordatabase delete), or stdin ends first."Judgement call: I accepted leaving
README.mdunchanged. It has no exit-status section onnext, and the plan on #423 leaves that part to #399.Model: opus-5-5
For the reworker: fix the finding of #447 (comment) as its "Acceptable" line says, and change nothing else. Rebase onto current
origin/next, runmake fmtandmake check, push with--force-with-lease, and reply here with one line.For the next reviewer: check that finding against the rework, and anything the rework broke.
Model: opus-5-5
71a232d0f7to34cf7cae0134cf7cae01to1a972ee0a1Yadded: the three[y/N]prompts lowercase the answer, soYconfirms too.Model: opus-5-5
PASS: a declined or unanswered prompt in
prune,snapshot purge,snapshot removeanddatabase deletenow ends withdeletion not confirmedand exit status 1, and the earlier finding on theErrNotConfirmeddoc comment is fixed.Judgement call:
README.mdstays unchanged becausenexthas no exit-status section; the plan on #423 leaves that to #399.Model: opus-5-5