What was wrong: the summary printed by the local index cleanup at the start of every snapshot create (and by prune) put the number of snapshots, files, chunks or blobs left in the local index in brackets as "(N remain)". On lines headed "Incomplete snapshots" and "Orphaned files" that reads as incomplete or orphaned rows left over, so removing the only incomplete snapshot printed "1 removed (1 remain)".
What changed: each of the four lines in PruneDatabase now labels the figure as the total of its kind left in the local index, for example "Incomplete snapshots: 1 removed (total snapshots left in the local index: 1)." The figures are unchanged. A new test removes the only incomplete snapshot from an index that also holds a complete one and checks all four lines.
Judgement call: the definition of done allowed either counting the incomplete or orphaned rows left, or labelling the totals; labelling the totals needs no new queries, so that is the one taken.
Model: opus-5-5
Fixes https://git.eeqj.de/sneak/vaultik/issues/306.
**What was wrong:** the summary printed by the local index cleanup at the start of every `snapshot create` (and by `prune`) put the number of snapshots, files, chunks or blobs left in the local index in brackets as "(N remain)". On lines headed "Incomplete snapshots" and "Orphaned files" that reads as incomplete or orphaned rows left over, so removing the only incomplete snapshot printed "1 removed (1 remain)".
**What changed:** each of the four lines in `PruneDatabase` now labels the figure as the total of its kind left in the local index, for example "Incomplete snapshots: 1 removed (total snapshots left in the local index: 1)." The figures are unchanged. A new test removes the only incomplete snapshot from an index that also holds a complete one and checks all four lines.
Judgement call: the definition of done allowed either counting the incomplete or orphaned rows left, or labelling the totals; labelling the totals needs no new queries, so that is the one taken.
Model: opus-5-5
The summary printed by the local index cleanup before each backup gave,
in brackets after each removed count, the number of snapshots, files,
chunks or blobs left in the local index, worded "(N remain)", which
read as incomplete or orphaned rows left over: removing the only
incomplete snapshot printed "1 removed (1 remain)". Each line now
labels that figure as the total of its kind left in the local index.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #306.
What was wrong: the summary printed by the local index cleanup at the start of every
snapshot create(and byprune) put the number of snapshots, files, chunks or blobs left in the local index in brackets as "(N remain)". On lines headed "Incomplete snapshots" and "Orphaned files" that reads as incomplete or orphaned rows left over, so removing the only incomplete snapshot printed "1 removed (1 remain)".What changed: each of the four lines in
PruneDatabasenow labels the figure as the total of its kind left in the local index, for example "Incomplete snapshots: 1 removed (total snapshots left in the local index: 1)." The figures are unchanged. A new test removes the only incomplete snapshot from an index that also holds a complete one and checks all four lines.Judgement call: the definition of done allowed either counting the incomplete or orphaned rows left, or labelling the totals; labelling the totals needs no new queries, so that is the one taken.
Model: opus-5-5
Review passed.
Model: opus-5-5