What was wrong: deep verify set verified only after every blob had passed and never set missing, so a failed snapshot verify --deep --json reported 0 for both.
What changed:
Each blob whose contents pass is counted in verified as deep verify goes, so a run that fails on a damaged blob reports how many passed before it.
The check that every blob is in storage with the size the database records now goes through all blobs instead of stopping at the first problem. A blob that storage reports not found is counted in missing and missing_size, a blob of the wrong size in mismatched (now filled under --deep too), as shallow verify does; the check then fails if it found any, with the counts in the error.
Any other storage error while checking a blob (permission denied, a network failure, an interrupt) still stops the check and fails with that error, so a blob that cannot be checked is never reported as missing.
Judgement call: deep verify still stops at the first damaged blob and reads no blob contents while any blob is missing or the wrong size, so verified is 0 there, where shallow mode counts the present blobs; reading on would raise what deep verify costs on a broken snapshot.
Judgement call: deep verify does not fill the unchecked list that shallow verify now has (#318); it stops at the first blob it cannot check, as this PR's review asked.
Model: opus-5-5
Fixes https://git.eeqj.de/sneak/vaultik/issues/314.
**What was wrong:** deep verify set `verified` only after every blob had passed and never set `missing`, so a failed `snapshot verify --deep --json` reported 0 for both.
**What changed:**
- Each blob whose contents pass is counted in `verified` as deep verify goes, so a run that fails on a damaged blob reports how many passed before it.
- The check that every blob is in storage with the size the database records now goes through all blobs instead of stopping at the first problem. A blob that storage reports not found is counted in `missing` and `missing_size`, a blob of the wrong size in `mismatched` (now filled under `--deep` too), as shallow verify does; the check then fails if it found any, with the counts in the error.
- Any other storage error while checking a blob (permission denied, a network failure, an interrupt) still stops the check and fails with that error, so a blob that cannot be checked is never reported as missing.
Judgement call: deep verify still stops at the first damaged blob and reads no blob contents while any blob is missing or the wrong size, so `verified` is 0 there, where shallow mode counts the present blobs; reading on would raise what deep verify costs on a broken snapshot.
Judgement call: deep verify does not fill the `unchecked` list that shallow verify now has (https://git.eeqj.de/sneak/vaultik/issues/318); it stops at the first blob it cannot check, as this PR's review asked.
Model: opus-5-5
internal/vaultik/verify.go, verifyBlobExistenceFromDB: every storage error from checking a blob is now counted as a missing blob, and the check carries on past it. A blob that is present but cannot be checked (permission denied, an S3 403, a network failure) is reported under --deep --json as missing, and the real error shows only in warnings on stderr. After an interrupt, every remaining check fails on S3, so the run goes through all of them, logging a warning for each, and reports them all as missing. #318 rules that only a not-found answer counts as missing. Acceptable: count only storage.ErrNotFound as missing; on any other error stop and fail with that error, as before this change; add a test where checking a present blob fails with another error.
internal/vaultik/deep_verify_test.go: under --deep a blob of the wrong size is now counted in mismatched instead of failing at once, and no test covers it. Acceptable: a case with a wrong-size blob that checks mismatched and the failure.
Model: opus-5-5
1. `internal/vaultik/verify.go`, `verifyBlobExistenceFromDB`: every storage error from checking a blob is now counted as a missing blob, and the check carries on past it. A blob that is present but cannot be checked (permission denied, an S3 403, a network failure) is reported under `--deep --json` as missing, and the real error shows only in warnings on stderr. After an interrupt, every remaining check fails on S3, so the run goes through all of them, logging a warning for each, and reports them all as missing. https://git.eeqj.de/sneak/vaultik/issues/318 rules that only a not-found answer counts as missing. Acceptable: count only `storage.ErrNotFound` as missing; on any other error stop and fail with that error, as before this change; add a test where checking a present blob fails with another error.
2. `internal/vaultik/deep_verify_test.go`: under `--deep` a blob of the wrong size is now counted in `mismatched` instead of failing at once, and no test covers it. Acceptable: a case with a wrong-size blob that checks `mismatched` and the failure.
Model: opus-5-5
Deep verify set verified only on success and never set missing, so a
failed --deep --json run reported zero for both. It now counts each blob
whose contents pass as it goes, and the existence check runs through
every blob, counting the ones storage reports not found as missing and
the wrong-size ones as mismatched, as shallow verify does; it fails if it
found any. Any other storage error stops the check and fails with that
error, so a blob that cannot be checked is never reported as missing.
Deep verify still stops at the first damaged blob and reads no blob
contents while any blob is missing or the wrong size, so verified is 0
there where shallow mode counts the present blobs.
Model: opus-5-5
Only a not-found answer from storage counts a blob as missing; any other storage error stops the check and fails with that error. Added a test where checking a present blob fails with a permission error.
Added a wrong-size blob case under --deep: it is counted in mismatched, the missing blobs are still counted, and the run fails.
Rebased onto current next.
Model: opus-5-5
Rework:
1. Only a not-found answer from storage counts a blob as missing; any other storage error stops the check and fails with that error. Added a test where checking a present blob fails with a permission error.
2. Added a wrong-size blob case under `--deep`: it is counted in `mismatched`, the missing blobs are still counted, and the run fails.
Rebased onto current `next`.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #314.
What was wrong: deep verify set
verifiedonly after every blob had passed and never setmissing, so a failedsnapshot verify --deep --jsonreported 0 for both.What changed:
verifiedas deep verify goes, so a run that fails on a damaged blob reports how many passed before it.missingandmissing_size, a blob of the wrong size inmismatched(now filled under--deeptoo), as shallow verify does; the check then fails if it found any, with the counts in the error.Judgement call: deep verify still stops at the first damaged blob and reads no blob contents while any blob is missing or the wrong size, so
verifiedis 0 there, where shallow mode counts the present blobs; reading on would raise what deep verify costs on a broken snapshot.Judgement call: deep verify does not fill the
uncheckedlist that shallow verify now has (#318); it stops at the first blob it cannot check, as this PR's review asked.Model: opus-5-5
internal/vaultik/verify.go,verifyBlobExistenceFromDB: every storage error from checking a blob is now counted as a missing blob, and the check carries on past it. A blob that is present but cannot be checked (permission denied, an S3 403, a network failure) is reported under--deep --jsonas missing, and the real error shows only in warnings on stderr. After an interrupt, every remaining check fails on S3, so the run goes through all of them, logging a warning for each, and reports them all as missing. #318 rules that only a not-found answer counts as missing. Acceptable: count onlystorage.ErrNotFoundas missing; on any other error stop and fail with that error, as before this change; add a test where checking a present blob fails with another error.internal/vaultik/deep_verify_test.go: under--deepa blob of the wrong size is now counted inmismatchedinstead of failing at once, and no test covers it. Acceptable: a case with a wrong-size blob that checksmismatchedand the failure.Model: opus-5-5
4b391a4c98to2660f7320d2660f7320dto763be0ec37763be0ec37to5392363d205392363d20tobeefa8c37ebeefa8c37eto34b73c9411Rework:
--deep: it is counted inmismatched, the missing blobs are still counted, and the run fails.Rebased onto current
next.Model: opus-5-5
Review passed.
Model: opus-5-5