What was wrong:ListObjects and ListObjectsStream in internal/s3/client.go walk a listing with the SDK paginator. The paginator takes a page marked truncated but carrying no continuation token for the last page and stops without an error. A server answering V2 listings V1-style sends such pages, so List and ListStream returned the first page as the whole listing, and prune treated the blobs of the snapshots on later pages as unreferenced.
What changed: both methods fetch each page through nextListPage, which returns the new ErrNoContinuationToken for such a page. Nothing that calls List or ListStream changed: prune, snapshot list and remote nuke already handle a listing error as a destination that cannot be listed, and prune then deletes nothing.
Test:TestS3ListingCutShortIsAnError points an S3 client at a stub server that answers every request with one such page, and checks that List and ListStream both fail with ErrNoContinuationToken.
Judgement call: the test serves a fixed reply from a stub server rather than wrapping gofakes3 as the issue's throwaway test did, since gofakes3 always sends the token and the wrapper would have to rewrite its replies.
Small extra: the region of the S3 clients in internal/storage/s3_test.go is now a constant, because a third copy of "us-east-1" in the package's tests failed the lint check for repeated strings.
Model: opus-5-5
Fixes https://git.eeqj.de/sneak/vaultik/issues/297.
**What was wrong:** `ListObjects` and `ListObjectsStream` in `internal/s3/client.go` walk a listing with the SDK paginator. The paginator takes a page marked truncated but carrying no continuation token for the last page and stops without an error. A server answering V2 listings V1-style sends such pages, so `List` and `ListStream` returned the first page as the whole listing, and `prune` treated the blobs of the snapshots on later pages as unreferenced.
**What changed:** both methods fetch each page through `nextListPage`, which returns the new `ErrNoContinuationToken` for such a page. Nothing that calls `List` or `ListStream` changed: `prune`, `snapshot list` and `remote nuke` already handle a listing error as a destination that cannot be listed, and `prune` then deletes nothing.
**Test:** `TestS3ListingCutShortIsAnError` points an S3 client at a stub server that answers every request with one such page, and checks that `List` and `ListStream` both fail with `ErrNoContinuationToken`.
Judgement call: the test serves a fixed reply from a stub server rather than wrapping gofakes3 as the issue's throwaway test did, since gofakes3 always sends the token and the wrapper would have to rewrite its replies.
Small extra: the region of the S3 clients in `internal/storage/s3_test.go` is now a constant, because a third copy of `"us-east-1"` in the package's tests failed the lint check for repeated strings.
Model: opus-5-5
Needs a rebase: the branch conflicts with current next in TODO.md, where the Completed Steps entry for #298 landed at the same spot as this PR's entry. Acceptable: rebase onto current next keeping both entries, this PR's 2026-10-13 entry above the #298 one.
Model: opus-5-5
- Needs a rebase: the branch conflicts with current `next` in `TODO.md`, where the Completed Steps entry for https://git.eeqj.de/sneak/vaultik/issues/298 landed at the same spot as this PR's entry. Acceptable: rebase onto current `next` keeping both entries, this PR's 2026-10-13 entry above the #298 one.
Model: opus-5-5
The SDK paginator takes a listing page marked truncated but carrying no
continuation token for the last page and stops without an error. A
server answering V2 listings V1-style sends such pages, so ListObjects
and ListObjectsStream returned the first page as the whole listing, and
prune treated the blobs of the snapshots on later pages as unreferenced.
Both now fetch each page through nextListPage, which returns
ErrNoContinuationToken for such a page; prune, snapshot list and remote
nuke already handle a listing error.
The test serves a fixed reply from a stub server, since gofakes3 always
sends the token.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #297.
What was wrong:
ListObjectsandListObjectsStreamininternal/s3/client.gowalk a listing with the SDK paginator. The paginator takes a page marked truncated but carrying no continuation token for the last page and stops without an error. A server answering V2 listings V1-style sends such pages, soListandListStreamreturned the first page as the whole listing, andprunetreated the blobs of the snapshots on later pages as unreferenced.What changed: both methods fetch each page through
nextListPage, which returns the newErrNoContinuationTokenfor such a page. Nothing that callsListorListStreamchanged:prune,snapshot listandremote nukealready handle a listing error as a destination that cannot be listed, andprunethen deletes nothing.Test:
TestS3ListingCutShortIsAnErrorpoints an S3 client at a stub server that answers every request with one such page, and checks thatListandListStreamboth fail withErrNoContinuationToken.Judgement call: the test serves a fixed reply from a stub server rather than wrapping gofakes3 as the issue's throwaway test did, since gofakes3 always sends the token and the wrapper would have to rewrite its replies.
Small extra: the region of the S3 clients in
internal/storage/s3_test.gois now a constant, because a third copy of"us-east-1"in the package's tests failed the lint check for repeated strings.Model: opus-5-5
nextinTODO.md, where the Completed Steps entry for #298 landed at the same spot as this PR's entry. Acceptable: rebase onto currentnextkeeping both entries, this PR's 2026-10-13 entry above the #298 one.Model: opus-5-5
86ec0df2e7to43483e21d4Review passed. Needs a rebase (TODO.md only).
Model: opus-5-5
43483e21d4to4bb264b013