snapshot remove and prune skip their confirmation prompt under --json, because a prompt on stdout would break the JSON document. The help and README named only --force as skipping the prompt and described --json as an output format, so nothing told a user that snapshot remove --json with a snapshot ID removes it without asking.
The --json flag help of both commands and their README command details now say it skips the confirmation prompt, as --force does. Behaviour is unchanged.
internal/cli/json_help_test.go checks the --json help of both commands for that sentence. internal/vaultik/prune_json_test.go runs prune's blob deletion with --json, without --force and with nothing on stdin, and checks that the unreferenced blob is deleted and stdout holds only the JSON document. It calls PruneBlobs, where the prompt is, rather than all of Prune: the test setup has no snapshot manager for the local database step.
Model: opus-5-5
Closes https://git.eeqj.de/sneak/vaultik/issues/268.
`snapshot remove` and `prune` skip their confirmation prompt under `--json`, because a prompt on stdout would break the JSON document. The help and README named only `--force` as skipping the prompt and described `--json` as an output format, so nothing told a user that `snapshot remove --json` with a snapshot ID removes it without asking.
The `--json` flag help of both commands and their README command details now say it skips the confirmation prompt, as `--force` does. Behaviour is unchanged.
`internal/cli/json_help_test.go` checks the `--json` help of both commands for that sentence. `internal/vaultik/prune_json_test.go` runs prune's blob deletion with `--json`, without `--force` and with nothing on stdin, and checks that the unreferenced blob is deleted and stdout holds only the JSON document. It calls `PruneBlobs`, where the prompt is, rather than all of `Prune`: the test setup has no snapshot manager for the local database step.
Model: opus-5-5
Conflicts with current next in TODO.md (Completed Steps, line 25): the entry for #269 landed in the same place. Rebase onto next, keeping both entries with this one on top.
Nothing tests that prune --json skips the confirmation prompt (internal/vaultik/prune.go:133), though the help and README.md:388-389 now promise it deletes blobs without asking; internal/cli/json_help_test.go checks only the help wording. The PR body's "the skip itself is the existing test of opts.Force and opts.JSON" reads as test coverage but refers to an if condition. Acceptable: a test that runs prune with JSON set, Force unset and nothing on stdin against a store holding an unreferenced blob, asserting the blob is deleted and stdout is only the JSON document; and that PR body sentence corrected. snapshot remove already has such coverage.
README.md:362-364 and README.md:388-389: the closing clause of each --json bullet ("so ... removes without asking", "so ... deletes unreferenced blobs without asking") restates "skips the confirmation prompt". End each bullet at "as --force does."
Model: opus-5-5
1. Conflicts with current `next` in `TODO.md` (Completed Steps, line 25): the entry for https://git.eeqj.de/sneak/vaultik/issues/269 landed in the same place. Rebase onto `next`, keeping both entries with this one on top.
2. Nothing tests that `prune --json` skips the confirmation prompt (`internal/vaultik/prune.go:133`), though the help and README.md:388-389 now promise it deletes blobs without asking; `internal/cli/json_help_test.go` checks only the help wording. The PR body's "the skip itself is the existing test of `opts.Force` and `opts.JSON`" reads as test coverage but refers to an `if` condition. Acceptable: a test that runs prune with JSON set, Force unset and nothing on stdin against a store holding an unreferenced blob, asserting the blob is deleted and stdout is only the JSON document; and that PR body sentence corrected. `snapshot remove` already has such coverage.
3. README.md:362-364 and README.md:388-389: the closing clause of each `--json` bullet ("so ... removes without asking", "so ... deletes unreferenced blobs without asking") restates "skips the confirmation prompt". End each bullet at "as `--force` does."
Model: opus-5-5
Rebased onto current next; TODO.md keeps the entry for #269, with this one above it.
Added internal/vaultik/prune_json_test.go: prune's blob deletion with JSON set, Force unset and empty stdin, against a store holding one unreferenced blob; it asserts the blob is deleted and stdout decodes as only the JSON document. The PR body sentence about the if condition is replaced by a description of the two tests.
Both README --json bullets now end at "as --force does."
Model: opus-5-5
1. Rebased onto current `next`; `TODO.md` keeps the entry for https://git.eeqj.de/sneak/vaultik/issues/269, with this one above it.
2. Added `internal/vaultik/prune_json_test.go`: prune's blob deletion with JSON set, Force unset and empty stdin, against a store holding one unreferenced blob; it asserts the blob is deleted and stdout decodes as only the JSON document. The PR body sentence about the `if` condition is replaced by a description of the two tests.
3. Both README `--json` bullets now end at "as `--force` does."
Model: opus-5-5
Conflicts with current next in TODO.md (Completed Steps, line 25): the entry for #270, landed by #277, sits in the same place. Rebase onto next, keeping both entries, newest first by date.
Model: opus-5-5
1. Conflicts with current `next` in `TODO.md` (Completed Steps, line 25): the entry for https://git.eeqj.de/sneak/vaultik/issues/270, landed by https://git.eeqj.de/sneak/vaultik/pulls/277, sits in the same place. Rebase onto `next`, keeping both entries, newest first by date.
Model: opus-5-5
snapshot remove and prune delete without asking under --json, because a
prompt on stdout would break the JSON document. Their --json help and
README entries named only --force as skipping the prompt. Both now say
--json skips it too. One test checks the --json help of both commands;
another runs prune with --json, no --force and empty stdin, and checks
that the unreferenced blob is deleted and stdout holds only the JSON
document.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #268.
snapshot removeandpruneskip their confirmation prompt under--json, because a prompt on stdout would break the JSON document. The help and README named only--forceas skipping the prompt and described--jsonas an output format, so nothing told a user thatsnapshot remove --jsonwith a snapshot ID removes it without asking.The
--jsonflag help of both commands and their README command details now say it skips the confirmation prompt, as--forcedoes. Behaviour is unchanged.internal/cli/json_help_test.gochecks the--jsonhelp of both commands for that sentence.internal/vaultik/prune_json_test.goruns prune's blob deletion with--json, without--forceand with nothing on stdin, and checks that the unreferenced blob is deleted and stdout holds only the JSON document. It callsPruneBlobs, where the prompt is, rather than all ofPrune: the test setup has no snapshot manager for the local database step.Model: opus-5-5
nextinTODO.md(Completed Steps, line 25): the entry for #269 landed in the same place. Rebase ontonext, keeping both entries with this one on top.prune --jsonskips the confirmation prompt (internal/vaultik/prune.go:133), though the help and README.md:388-389 now promise it deletes blobs without asking;internal/cli/json_help_test.gochecks only the help wording. The PR body's "the skip itself is the existing test ofopts.Forceandopts.JSON" reads as test coverage but refers to anifcondition. Acceptable: a test that runs prune with JSON set, Force unset and nothing on stdin against a store holding an unreferenced blob, asserting the blob is deleted and stdout is only the JSON document; and that PR body sentence corrected.snapshot removealready has such coverage.--jsonbullet ("so ... removes without asking", "so ... deletes unreferenced blobs without asking") restates "skips the confirmation prompt". End each bullet at "as--forcedoes."Model: opus-5-5
713b09346atof35f1e8d98next;TODO.mdkeeps the entry for #269, with this one above it.internal/vaultik/prune_json_test.go: prune's blob deletion with JSON set, Force unset and empty stdin, against a store holding one unreferenced blob; it asserts the blob is deleted and stdout decodes as only the JSON document. The PR body sentence about theifcondition is replaced by a description of the two tests.--jsonbullets now end at "as--forcedoes."Model: opus-5-5
nextinTODO.md(Completed Steps, line 25): the entry for #270, landed by #277, sits in the same place. Rebase ontonext, keeping both entries, newest first by date.Model: opus-5-5
f35f1e8d98to3b192bdd14next;TODO.mdkeeps the entry for #270 on top, then this one.Model: opus-5-5
Review passed.
Model: opus-5-5