internal/cli/snapshot_restore_test.go imports github.com/spf13/pflag directly, but go.mod still marked it // indirect. script/precommit runs go mod tidy and fails when that changes go.mod, so the hook installed by script/setup stopped every commit on next.
The go.mod change is the output of go mod tidy, not a hand edit. pflag moves from the indirect block to the direct require block at the same version, and go.sum does not change.
script/cibuild does not run go mod tidy, which is why CI did not catch this; it will not catch the next one either. That is outside this issue.
Judgement call: no Go test added. The check that reproduces the defect is script/precommit itself, which failed on next at 14fc4c9 before this change.
#245 also edits go.mod (it moves golang.org/x/sys to the direct block). Whichever lands second needs a rebase and a fresh go mod tidy.
Model: opus-5-5
Closes https://git.eeqj.de/sneak/vaultik/issues/246.
`internal/cli/snapshot_restore_test.go` imports `github.com/spf13/pflag` directly, but `go.mod` still marked it `// indirect`. `script/precommit` runs `go mod tidy` and fails when that changes `go.mod`, so the hook installed by `script/setup` stopped every commit on `next`.
The `go.mod` change is the output of `go mod tidy`, not a hand edit. `pflag` moves from the indirect block to the direct `require` block at the same version, and `go.sum` does not change.
`script/cibuild` does not run `go mod tidy`, which is why CI did not catch this; it will not catch the next one either. That is outside this issue.
- Judgement call: no Go test added. The check that reproduces the defect is `script/precommit` itself, which failed on `next` at `14fc4c9` before this change.
- https://git.eeqj.de/sneak/vaultik/pulls/245 also edits `go.mod` (it moves `golang.org/x/sys` to the direct block). Whichever lands second needs a rebase and a fresh `go mod tidy`.
Model: opus-5-5
internal/cli/snapshot_restore_test.go imports github.com/spf13/pflag
directly, but go.mod still marked it // indirect. script/precommit runs
go mod tidy and fails when that changes go.mod, so the pre-commit hook
stopped every commit. This is the go mod tidy output: pflag moves to the
direct require block, and go.sum does not change. script/cibuild does
not run the tidy, which is why the gate stayed green.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #246.
internal/cli/snapshot_restore_test.goimportsgithub.com/spf13/pflagdirectly, butgo.modstill marked it// indirect.script/precommitrunsgo mod tidyand fails when that changesgo.mod, so the hook installed byscript/setupstopped every commit onnext.The
go.modchange is the output ofgo mod tidy, not a hand edit.pflagmoves from the indirect block to the directrequireblock at the same version, andgo.sumdoes not change.script/cibuilddoes not rungo mod tidy, which is why CI did not catch this; it will not catch the next one either. That is outside this issue.script/precommititself, which failed onnextat14fc4c9before this change.go.mod(it movesgolang.org/x/systo the direct block). Whichever lands second needs a rebase and a freshgo mod tidy.Model: opus-5-5
Review passed.
Model: opus-5-5