Removes the skip from TestRestoreReportsDiskFull, the restore-runs-out-of-space case of #72, and drops its "skipped until" wording, for #207. The skip waited on #163, which is closed.
Restore is not changed. With the skip removed, the test failed because restore succeeded: the test's simulated full disk capped only Create, but since d9f0220 restore opens each file with OpenFile, so no write was ever capped. The simulated disk now caps OpenFile instead.
It caps only files under the restore target. Restore also writes the decrypted metadata database under $TMPDIR through the same filesystem; capping that would fail the restore before any file reached the target, and the check for a partial file at the target would then check nothing.
Both assertions are unchanged: restore must fail with an out-of-space error, and any file at the target must hold the original bytes or be absent.
Judgement call: the test was wrong (its simulated full disk never failed a write restore makes), so the test was corrected rather than restore.
Model: opus-5-5
Removes the skip from `TestRestoreReportsDiskFull`, the restore-runs-out-of-space case of https://git.eeqj.de/sneak/vaultik/issues/72, and drops its "skipped until" wording, for https://git.eeqj.de/sneak/vaultik/issues/207. The skip waited on https://git.eeqj.de/sneak/vaultik/issues/163, which is closed.
Restore is not changed. With the skip removed, the test failed because restore succeeded: the test's simulated full disk capped only `Create`, but since `d9f0220` restore opens each file with `OpenFile`, so no write was ever capped. The simulated disk now caps `OpenFile` instead.
It caps only files under the restore target. Restore also writes the decrypted metadata database under `$TMPDIR` through the same filesystem; capping that would fail the restore before any file reached the target, and the check for a partial file at the target would then check nothing.
Both assertions are unchanged: restore must fail with an out-of-space error, and any file at the target must hold the original bytes or be absent.
Judgement call: the test was wrong (its simulated full disk never failed a write restore makes), so the test was corrected rather than restore.
Model: opus-5-5
TestRestoreReportsDiskFull was skipped pending
#163, which is closed. The skip
and its "skipped until" wording are removed.
Restore is unchanged. With the skip removed the test failed because
restore succeeded: its simulated full disk capped only Create, but
restore now opens each file with OpenFile, so nothing was capped. It now
caps OpenFile, and only for files under the restore target: restore also
writes the decrypted metadata database under $TMPDIR through the same
filesystem, and capping that would fail the restore before any file
reached the target.
Judgement call: the test was corrected, not restore; both assertions are
unchanged.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Removes the skip from
TestRestoreReportsDiskFull, the restore-runs-out-of-space case of #72, and drops its "skipped until" wording, for #207. The skip waited on #163, which is closed.Restore is not changed. With the skip removed, the test failed because restore succeeded: the test's simulated full disk capped only
Create, but sinced9f0220restore opens each file withOpenFile, so no write was ever capped. The simulated disk now capsOpenFileinstead.It caps only files under the restore target. Restore also writes the decrypted metadata database under
$TMPDIRthrough the same filesystem; capping that would fail the restore before any file reached the target, and the check for a partial file at the target would then check nothing.Both assertions are unchanged: restore must fail with an out-of-space error, and any file at the target must hold the original bytes or be absent.
Judgement call: the test was wrong (its simulated full disk never failed a write restore makes), so the test was corrected rather than restore.
Model: opus-5-5
Review passed.
Model: opus-5-5